| Message ID | 20220128141253.2558990-1-lsahlber@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | cifs: add a warning that SMB 1.0 is deprecated and will be phased out in 12 months | expand |
diff --git a/fs/cifs/fs_context.c b/fs/cifs/fs_context.c index 7ec35f3f0a5f..80caddebdad8 100644 --- a/fs/cifs/fs_context.c +++ b/fs/cifs/fs_context.c @@ -342,6 +342,7 @@ cifs_parse_smb_version(struct fs_context *fc, char *value, struct smb3_fs_contex switch (match_token(value, cifs_smb_version_tokens, args)) { #ifdef CONFIG_CIFS_ALLOW_INSECURE_LEGACY case Smb_1: + cifs_errorf(fc, "WARNING: SMB1 is deprecated and will be removed from CIFS.KO in 2023. Please migrate to SMB2 or later.\n"); if (disable_legacy_dialects) { cifs_errorf(fc, "mount with legacy dialect disabled\n"); return 1;
SMB1.0 was deprecated a long time ago. The code is very old, fragile and has fragile bufferhandling. There is no support or maintenacne of this dialect since a long time. Additionally, the protocol is much less rich than SMB2 and and has semantic differences which leads to unreasonable maintenance burdens. Examples are: Rename ontop of an open file that has Delete-on-close set. Compounding support, encryption support. Warn that this protocol version is deprecated and will be removed from cifs.ko in 12 months time. Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com> --- fs/cifs/fs_context.c | 1 + 1 file changed, 1 insertion(+)