diff mbox series

[v1] cifs: Add missing sentinel to smb3_fs_parameters

Message ID 20201214113745.7909-1-digetx@gmail.com
State New
Headers show
Series [v1] cifs: Add missing sentinel to smb3_fs_parameters | expand

Commit Message

Dmitry Osipenko Dec. 14, 2020, 11:37 a.m. UTC
Add missing sentinel to smb3_fs_parameters. This fixes ARM32 kernel
crashing once CIFS is registered.

 Unable to handle kernel paging request at virtual address 33626d73
...
 (strcmp) from (fs_validate_description)
 (fs_validate_description) from (register_filesystem)
 (register_filesystem) from (init_cifs [cifs])
 (init_cifs [cifs]) from (do_one_initcall)
 (do_one_initcall) from (do_init_module)
 (do_init_module) from (load_module)
 (load_module) from (sys_finit_module)
 (sys_finit_module) from (ret_fast_syscal)

Fixes: e07724d1cf38 ("cifs: switch to new mount api")
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 fs/cifs/fs_context.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Aurélien Aptel Dec. 14, 2020, 12:19 p.m. UTC | #1
Dmitry Osipenko <digetx@gmail.com> writes:
> Add missing sentinel to smb3_fs_parameters. This fixes ARM32 kernel
> crashing once CIFS is registered.

Thanks for the fix Dmitry.

Reviewed-by: Aurelien Aptel <aaptel@suse.com>

Cheers,
diff mbox series

Patch

diff --git a/fs/cifs/fs_context.c b/fs/cifs/fs_context.c
index fe5cc60f4393..c41e87af77b6 100644
--- a/fs/cifs/fs_context.c
+++ b/fs/cifs/fs_context.c
@@ -173,6 +173,7 @@  const struct fs_parameter_spec smb3_fs_parameters[] = {
 	fsparam_flag_no("mand", Opt_ignore),
 	fsparam_string("cred", Opt_ignore),
 	fsparam_string("credentials", Opt_ignore),
+	{}
 };
 
 int