diff mbox series

SMB3: Fix persistent handles reconnect

Message ID 20191107191322.4360-1-pshilov@microsoft.com
State New
Headers show
Series SMB3: Fix persistent handles reconnect | expand

Commit Message

Pavel Shilovsky Nov. 7, 2019, 7:13 p.m. UTC
When the client hits a network reconnect, it re-opens every open
file with a create context to reconnect a persistent handle. All
create context types should be 8-bytes aligned but the padding
was missed for that one. As a result, the server doesn't allow
to reconnect handles and returns an error. The problem occurs
when the problematic context is not at the end of the create
request packet. Fix this by adding a proper padding at the end
of the reconnect persistent handle context.

Cc: Stable <stable@vger.kernel.org> # 4.19.x
Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
 fs/cifs/smb2pdu.h | 1 +
 1 file changed, 1 insertion(+)
diff mbox series


diff --git a/fs/cifs/smb2pdu.h b/fs/cifs/smb2pdu.h
index ea735d59c36e..0abfde6d0b05 100644
--- a/fs/cifs/smb2pdu.h
+++ b/fs/cifs/smb2pdu.h
@@ -838,6 +838,7 @@  struct create_durable_handle_reconnect_v2 {
 	struct create_context ccontext;
 	__u8   Name[8];
 	struct durable_reconnect_context_v2 dcontext;
+	__u8   Pad[4];
 } __packed;
 /* See MS-SMB2 */