From patchwork Wed Oct 31 22:13:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Long Li X-Patchwork-Id: 991736 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-cifs-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linuxonhyperv.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42ljLT4TYZz9sBQ for ; Thu, 1 Nov 2018 09:14:41 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726897AbeKAHOf (ORCPT ); Thu, 1 Nov 2018 03:14:35 -0400 Received: from a2nlsmtp01-05.prod.iad2.secureserver.net ([198.71.225.49]:46978 "EHLO a2nlsmtp01-05.prod.iad2.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725755AbeKAHOf (ORCPT ); Thu, 1 Nov 2018 03:14:35 -0400 Received: from linuxonhyperv2.linuxonhyperv.com ([107.180.71.197]) by : HOSTING RELAY : with ESMTP id Hyk2g4ZDjbOGjHyk2gzy2j; Wed, 31 Oct 2018 15:13:34 -0700 x-originating-ip: 107.180.71.197 Received: from longli by linuxonhyperv2.linuxonhyperv.com with local (Exim 4.91) (envelope-from ) id 1gHyk1-0000gk-VS; Wed, 31 Oct 2018 15:13:34 -0700 From: Long Li To: Steve French , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org Cc: Long Li Subject: [Patch v4 3/3] CIFS: Add direct I/O functions to file_operations Date: Wed, 31 Oct 2018 22:13:11 +0000 Message-Id: <20181031221311.2596-3-longli@linuxonhyperv.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181031221311.2596-1-longli@linuxonhyperv.com> References: <20181031221311.2596-1-longli@linuxonhyperv.com> Reply-To: longli@microsoft.com X-CMAE-Envelope: MS4wfGEI+e0OWB/Cv8nU4vELvGFJ0VfqsDNujUeSkcNDOBjrLEpJQPs6PPQIYRmdIWBmrhOe/cQ7BU7OXLSrwTRidz+0T9IIKxL3r7QEwOp2tAZ4ZbXkcMNl A+33LDBTREt0vZzB5TPQ2z+3rMqbKzItg4LrgZrO7WJ756IcomaWIXD8034SRmAwZ6EpFB0P0Zt09cGf2JRqGszeMinTZKHGgIshmP0FzDTlz78s5eP3BqrQ 5fe/1hxvqyNtt4pPwTPOgBkekb6K8MZ9DjZCKUYFYboF7vvWTBNQ+DkVI7y70zEXxs98X8ByThRu5u6CKtioWOEZa6QUtxYmfDcBj5x9ePFwER6VgPnO6gL4 /VObBeSZraG2/cDVBvzE/n1Lynigsw== Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org From: Long Li With direct read/write functions implemented, add them to file_operations. Dircet I/O is used under two conditions: 1. When mounting with "cache=none", CIFS uses direct I/O for all user file data transfer. 2. When opening a file with O_DIRECT, CIFS uses direct I/O for all data transfer on this file. Signed-off-by: Long Li --- fs/cifs/cifsfs.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c index 62f1662..f18091b 100644 --- a/fs/cifs/cifsfs.c +++ b/fs/cifs/cifsfs.c @@ -1113,9 +1113,8 @@ const struct file_operations cifs_file_strict_ops = { }; const struct file_operations cifs_file_direct_ops = { - /* BB reevaluate whether they can be done with directio, no cache */ - .read_iter = cifs_user_readv, - .write_iter = cifs_user_writev, + .read_iter = cifs_direct_readv, + .write_iter = cifs_direct_writev, .open = cifs_open, .release = cifs_close, .lock = cifs_lock, @@ -1169,9 +1168,8 @@ const struct file_operations cifs_file_strict_nobrl_ops = { }; const struct file_operations cifs_file_direct_nobrl_ops = { - /* BB reevaluate whether they can be done with directio, no cache */ - .read_iter = cifs_user_readv, - .write_iter = cifs_user_writev, + .read_iter = cifs_direct_readv, + .write_iter = cifs_direct_writev, .open = cifs_open, .release = cifs_close, .fsync = cifs_fsync,