diff mbox series

iov_iter: Declare new iterator direction symbols

Message ID 1010626.1667584040@warthog.procyon.org.uk
State New
Headers show
Series iov_iter: Declare new iterator direction symbols | expand

Commit Message

David Howells Nov. 4, 2022, 5:47 p.m. UTC 
Hi Linus, Al,

If we're going to go with Al's changes to switch to using ITER_SOURCE and
ITER_DEST instead of READ/WRITE, can we put just the new symbols into mainline
now, even if we leave the rest for the next merge window?

Thanks,
David
---
From: Al Viro <viro@zeniv.linux.org.uk>

iov_iter: Declare new iterator direction symbols

READ/WRITE proved to be actively confusing - the meanings are
"data destination, as used with read(2)" and "data source, as
used with write(2)", but people keep interpreting those as
"we read data from it" and "we write data to it", i.e. exactly
the wrong way.

Call them ITER_DEST and ITER_SOURCE - at least that is harder
to misinterpret...

[dhowells] Declare the symbols for later use and change to an enum.  If
READ/WRITE are switched to an enum also, I think the compiler should
generate a warning if they're mixed.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/r/20221028023352.3532080-12-viro@zeniv.linux.org.uk/ # v2
---
 include/linux/uio.h |    5 +++++
 1 file changed, 5 insertions(+)

Comments

Linus Torvalds Nov. 4, 2022, 6:49 p.m. UTC | #1 
On Fri, Nov 4, 2022 at 10:47 AM David Howells <dhowells@redhat.com> wrote:
>
> If we're going to go with Al's changes to switch to using ITER_SOURCE and
> ITER_DEST instead of READ/WRITE, can we put just the new symbols into mainline
> now, even if we leave the rest for the next merge window?

No, I really don't want to have mixed-used stuff in the kernel.

Continue to use the old names until/if the conversion happens, at
which point it's the conversion code that does it.

No "one branch uses new names, another uses old names" mess.

               Linus
diff mbox series

Patch

diff --git a/include/linux/uio.h b/include/linux/uio.h
index 2e3134b14ffd..7c1317b34c57 100644
--- a/include/linux/uio.h
+++ b/include/linux/uio.h
@@ -29,6 +29,11 @@  enum iter_type {
 	ITER_UBUF,
 };
 
+enum iov_iter_direction {
+	ITER_DEST	= 0,	/* Iterator is a destination buffer (== READ) */
+	ITER_SOURCE	= 1,	/* Iterator is a source buffer (== WRITE) */
+};
+
 struct iov_iter_state {
 	size_t iov_offset;
 	size_t count;