mbox series

[0/6] Various fixes for multiuser SMB mounts

Message ID 20200626195809.429507-1-paul@darkrain42.org
Headers show
Series Various fixes for multiuser SMB mounts | expand

Message

Paul Aurich June 26, 2020, 7:58 p.m. UTC
Ensure several mount parameters work properly on multiuser mounts for non-root
users, and add the user ID / credentials user ID to the session output in
DebugData.

Note that the 'posix' fix is speculative, as I don't currently have a server
instance that supports SMB2 posix extensions.

Regards,
~Paul

Comments

Steve French June 29, 2020, 1:44 a.m. UTC | #1
these and the two others (one from one) recently posted tentatively
merged into cifs-2.6.git for-next pending review and testing

http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/5/builds/73

On Fri, Jun 26, 2020 at 3:07 PM Paul Aurich <paul@darkrain42.org> wrote:
>
> Ensure several mount parameters work properly on multiuser mounts for non-root
> users, and add the user ID / credentials user ID to the session output in
> DebugData.
>
> Note that the 'posix' fix is speculative, as I don't currently have a server
> instance that supports SMB2 posix extensions.
>
> Regards,
> ~Paul
>
>
Aurélien Aptel June 29, 2020, 9:39 a.m. UTC | #2
Thanks Paul!

All changes looks good to me and I think could be squashed into 1
commit: they are all adjusting the volume info used to mount from the master
tcon, all in the same func.

Reviewed-by: Aurelien Aptel <aaptel@suse.com>

Steve French <smfrench@gmail.com> writes:
> these and the two others (one from one) recently posted tentatively
> merged into cifs-2.6.git for-next pending review and testing

I don't think we have any multiuser tests, sadly :(

Cheers,
Paul Aurich June 30, 2020, 2:43 a.m. UTC | #3
On 2020-06-29 11:39:02 +0200, Aurélien Aptel wrote:
>Thanks Paul!
>
>All changes looks good to me and I think could be squashed into 1
>commit: they are all adjusting the volume info used to mount from the master
>tcon, all in the same func.

I kept them separate just because they may have different applicability to 
stable branches. As I wrote that, though, I realized I didn't test/check if 
they'd apply or not (because of ordering).

I don't mind if they're squashed.  (I can do that and resend if needed.)

>Reviewed-by: Aurelien Aptel <aaptel@suse.com>
>
>Steve French <smfrench@gmail.com> writes:
>> these and the two others (one from one) recently posted tentatively
>> merged into cifs-2.6.git for-next pending review and testing
>
>I don't think we have any multiuser tests, sadly :(
>
>Cheers,
>-- 
>Aurélien Aptel / SUSE Labs Samba Team
>GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
>SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
>GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
>

~Paul