From patchwork Thu Nov 2 07:02:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ronnie Sahlberg X-Patchwork-Id: 833220 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-cifs-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ySGKG68BXz9t2V for ; Thu, 2 Nov 2017 18:04:02 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751587AbdKBHD6 (ORCPT ); Thu, 2 Nov 2017 03:03:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40424 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752237AbdKBHD4 (ORCPT ); Thu, 2 Nov 2017 03:03:56 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 88FB04E917; Thu, 2 Nov 2017 07:03:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 88FB04E917 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lsahlber@redhat.com Received: from test1190.test.redhat.com (vpn2-54-17.bne.redhat.com [10.64.54.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id E218560C98; Thu, 2 Nov 2017 07:03:55 +0000 (UTC) From: Ronnie Sahlberg To: linux-cifs Cc: Steve French Subject: [PATCH 00/19] cifs: remove rfc1002 header from all smb2 requests Date: Thu, 2 Nov 2017 18:02:53 +1100 Message-Id: <20171102070312.18903-1-lsahlber@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 02 Nov 2017 07:03:56 +0000 (UTC) Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Steve, all I split the !1002 patch into a small serie for easier review. This patch series removes the NBSS 4 byte header from all the smb2 request structures. Instead of computing and tweaking the header as part of composing the SMB2 request, we now compute it in the new SendReceive3() function that is used by all of SMB2. This eliminates a huge amount of magic +4 / -4 in the code and all the ugly inc_rfc1002.... stuff where the old code would constantly tweak the length field as it was building the PDU. So overall it also simplifies the code in some places I think. This series is to prepare for and make it easier to add smb2 compounding in the future as then we will need to construct multiple SMB2 pdus and wrap them all insode one single rfc1002 header. As a later series, before we get to the actual compounding, I plan to do a similar change to all the reply structures and remove the rfc1002 header from them all too. Please review, and test. --- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html