| Message ID | f426c3a22d64d076b007a0fc75dc95a389a9387f.1676267865.git.jk@codeconstruct.com.au |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | Add definitions for AST2600 i3c clocks and resets | expand |
On 13/02/2023 07:02, Jeremy Kerr wrote: > This change adds the reset line definitions for the AST2600 I3C block's > reset inputs. 1. Do not use "This commit/patch". https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 2. This is not DTS. There is nothing from DTS here. Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). Best regards, Krzysztof
Hi Krzysztof, > 2. This is not DTS. There is nothing from DTS here. [and from, your reply on patch 2/3:] > Why do you use subject prefix in patch 1 different than in patch 2? Ack, will change to "clk:"; there is quite a mix of "dt-bindings:" and "clk:" on the changes within this dir. I'll unify across the series. Cheers, Jeremy
On 13/02/2023 10:02, Jeremy Kerr wrote: > Hi Krzysztof, > >> 2. This is not DTS. There is nothing from DTS here. > > [and from, your reply on patch 2/3:] > >> Why do you use subject prefix in patch 1 different than in patch 2? > > Ack, will change to "clk:"; there is quite a mix of "dt-bindings:" and > "clk:" on the changes within this dir. I'll unify across the series. > There was clk already, wasn't it? What do you want to change? I asked why do you call it in the same patchset aspeed and as2600? Best regards, Krzysztof
Hi Krzysztof, > There was clk already, wasn't it? What do you want to change? > I asked why do you call it in the same patchset aspeed and as2600? There was "clk" and "dts", where the latter should have probably been either also "clk" or "dt-bindings". I'll unify the "aspeed" to "ast2600". Cheers, Jeremy
On 13/02/2023 10:23, Jeremy Kerr wrote: > Hi Krzysztof, > >> There was clk already, wasn't it? What do you want to change? >> I asked why do you call it in the same patchset aspeed and as2600? > > There was "clk" and "dts", In patch 1 and 2? Please point me. > where the latter should have probably been either > also "clk" or "dt-bindings". Aren't you referring to some other comment now? > > I'll unify the "aspeed" to "ast2600". > > Cheers, > > > Jeremy Best regards, Krzysztof
diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h index 600549d7bee8..16b7389bbb9c 100644 --- a/include/dt-bindings/clock/ast2600-clock.h +++ b/include/dt-bindings/clock/ast2600-clock.h @@ -90,6 +90,12 @@ /* Only list resets here that are not part of a gate */ #define ASPEED_RESET_ADC 55 #define ASPEED_RESET_JTAG_MASTER2 54 +#define ASPEED_RESET_I3C5 45 +#define ASPEED_RESET_I3C4 44 +#define ASPEED_RESET_I3C3 43 +#define ASPEED_RESET_I3C2 42 +#define ASPEED_RESET_I3C1 41 +#define ASPEED_RESET_I3C0 40 #define ASPEED_RESET_I3C_DMA 39 #define ASPEED_RESET_PWM 37 #define ASPEED_RESET_PECI 36
This change adds the reset line definitions for the AST2600 I3C block's reset inputs. Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au> --- include/dt-bindings/clock/ast2600-clock.h | 6 ++++++ 1 file changed, 6 insertions(+)