Message ID | LV8PR11MB8463F88C2364A08DEF3ABAC28B7D2@LV8PR11MB8463.namprd11.prod.outlook.com |
---|---|
State | Changes Requested, archived |
Headers | show |
Series | JTAG driver introduction | expand |
On Tue, Jan 30, 2024 at 11:32:48PM +0000, Corona, Ernesto wrote: > Adding aspeed jtag device to device tree > > Signed-off-by: Ernesto Corona <ernesto.corona@intel.com> > Signed-off-by: Omar Castro <omar.eduardo.castro@linux.intel.com> > Acked-by: Arnd Bergmann <arnd@arndb.de> First of all, please use --thread to git-format-patch when preparing the series. > Cc: Jiri Pirko <jiri@nvidia.com> > Cc: Vadim Pasternak <vadimp@mellanox.com> > Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: David S. Miller <davem@davemloft.net> > Cc: Nicolas Ferre <nicolas.ferre@microchip.com> > Cc: Rob Herring <robh@kernel.org> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com> > Cc: Steven Filary <steven.a.filary@intel.com> > Cc: Amithash Prasad <amithash@fb.com> > Cc: Patrick Williams <patrickw3@fb.com> > Cc: Luke Chen <luke_chen@aspeedtech.com> > Cc: Billy Tsai <billy_tsai@aspeedtech.com> Second, please avoid flooding commit message with unneeded details, i.e. move these Cc:s to... > --- ...the after this cutter line.
On Thu, Feb 01, 2024 at 01:32:11PM +0200, 'andriy.shevchenko@linux.intel.com' wrote: > On Tue, Jan 30, 2024 at 11:32:48PM +0000, Corona, Ernesto wrote: > > Adding aspeed jtag device to device tree > > > > Signed-off-by: Ernesto Corona <ernesto.corona@intel.com> > > Signed-off-by: Omar Castro <omar.eduardo.castro@linux.intel.com> > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > First of all, please use --thread to git-format-patch when preparing the > series. > > > Cc: Jiri Pirko <jiri@nvidia.com> > > Cc: Vadim Pasternak <vadimp@mellanox.com> > > Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Cc: David S. Miller <davem@davemloft.net> > > Cc: Nicolas Ferre <nicolas.ferre@microchip.com> > > Cc: Rob Herring <robh@kernel.org> > > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com> > > Cc: Steven Filary <steven.a.filary@intel.com> > > Cc: Amithash Prasad <amithash@fb.com> > > Cc: Patrick Williams <patrickw3@fb.com> > > Cc: Luke Chen <luke_chen@aspeedtech.com> > > Cc: Billy Tsai <billy_tsai@aspeedtech.com> > > Second, please avoid flooding commit message with unneeded details, i.e. move > these Cc:s to... > > > --- > ...the after this cutter line. Also, you may use standard versioning pattern by using -v31 next time for git-format-patch (31 is an example, you may choose the correct version).
diff --git a/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi index 04f98d1dbb97..3610aa758702 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi +++ b/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi @@ -445,6 +445,15 @@ vuart: serial@1e787000 { status = "disabled"; }; + jtag: jtag@1e6e4000 { + compatible = "aspeed,ast2500-jtag"; + reg = <0x1e6e4000 0x1c>; + clocks = <&syscon ASPEED_CLK_APB>; + resets = <&syscon ASPEED_RESET_JTAG_MASTER>; + interrupts = <43>; + status = "disabled"; + }; + lpc: lpc@1e789000 { compatible = "aspeed,ast2500-lpc-v2", "simple-mfd", "syscon"; reg = <0x1e789000 0x1000>; diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi index c4d1faade8be..d5353f728689 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi @@ -411,6 +411,26 @@ xdma: xdma@1e6e7000 { status = "disabled"; }; + jtag0: jtag@1e6e4000 { + compatible = "aspeed,ast2600-jtag"; + reg = <0x1e6e4000 0x40>; + clocks = <&syscon ASPEED_CLK_APB1>; + resets = <&syscon ASPEED_RESET_JTAG_MASTER>; + interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + + jtag1: jtag@1e6e4100 { + compatible = "aspeed,ast2600-jtag"; + reg = <0x1e6e4100 0x40>; + clocks = <&syscon ASPEED_CLK_APB1>; + resets = <&syscon ASPEED_RESET_JTAG_MASTER2>; + interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_jtagm_default>; + status = "disabled"; + }; + adc0: adc@1e6e9000 { compatible = "aspeed,ast2600-adc0"; reg = <0x1e6e9000 0x100>;