| Message ID | 84315a29b453068373c096c03433e3a326731988.1575376664.git-series.andrew@aj.id.au |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | ipmi: kcs-bmc: Rework bindings to clean up DT warnings | expand |
On Tue, Dec 03, 2019 at 11:08:24PM +1030, Andrew Jeffery wrote: > The currently interrupts are configured after the channel was enabled. How about: The interrupts were configured after the channel was enabled, configure them before so they will work. -corey > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > Reviewed-by: Joel Stanley <joel@jms.id.au> > Reviewed-by: Haiyue Wang <haiyue.wang@linux.intel.com> > --- > drivers/char/ipmi/kcs_bmc_aspeed.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c > index 3c955946e647..e3dd09022589 100644 > --- a/drivers/char/ipmi/kcs_bmc_aspeed.c > +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c > @@ -268,13 +268,14 @@ static int aspeed_kcs_probe(struct platform_device *pdev) > kcs_bmc->io_inputb = aspeed_kcs_inb; > kcs_bmc->io_outputb = aspeed_kcs_outb; > > + rc = aspeed_kcs_config_irq(kcs_bmc, pdev); > + if (rc) > + return rc; > + > dev_set_drvdata(dev, kcs_bmc); > > aspeed_kcs_set_address(kcs_bmc, addr); > aspeed_kcs_enable_channel(kcs_bmc, true); > - rc = aspeed_kcs_config_irq(kcs_bmc, pdev); > - if (rc) > - return rc; > > rc = misc_register(&kcs_bmc->miscdev); > if (rc) { > -- > git-series 0.9.1
On Wed, 4 Dec 2019, at 00:10, Corey Minyard wrote: > On Tue, Dec 03, 2019 at 11:08:24PM +1030, Andrew Jeffery wrote: > > The currently interrupts are configured after the channel was enabled. > > How about: > > The interrupts were configured after the channel was enabled, configure > them before so they will work. Hah, yes, that commit message did get a bit mangled. I'll update it. Thanks, Andrew
diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c index 3c955946e647..e3dd09022589 100644 --- a/drivers/char/ipmi/kcs_bmc_aspeed.c +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c @@ -268,13 +268,14 @@ static int aspeed_kcs_probe(struct platform_device *pdev) kcs_bmc->io_inputb = aspeed_kcs_inb; kcs_bmc->io_outputb = aspeed_kcs_outb; + rc = aspeed_kcs_config_irq(kcs_bmc, pdev); + if (rc) + return rc; + dev_set_drvdata(dev, kcs_bmc); aspeed_kcs_set_address(kcs_bmc, addr); aspeed_kcs_enable_channel(kcs_bmc, true); - rc = aspeed_kcs_config_irq(kcs_bmc, pdev); - if (rc) - return rc; rc = misc_register(&kcs_bmc->miscdev); if (rc) {