| Message ID | 20240131084134.328307-12-Delphine_CC_Chiu@wiwynn.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Add i2c-mux and eeprom devices for Meta Yosemite 4 | expand |
On Wed, 2024-01-31 at 16:41 +0800, Delphine CC Chiu wrote: > Add eeprom for yosemite4 use > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> > --- > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > index e8d7eb7ff568..f00df378a371 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > @@ -932,7 +932,7 @@ temperature-sensor@4b { > }; > > eeprom@54 { > - compatible = "atmel,24c256"; > + compatible = "atmel,24c128"; This is changing an existing eeprom, not adding a new one - contrary to the commit message. It probably should be in a separate patch? Presumably this is also motivated by the change in the schematics? Some explanation would be helpful. I'm half wondering whether it would have been easier to add a separate DTS for the new version of the schematic rather than make all these piecemeal changes. Andrew
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts index e8d7eb7ff568..f00df378a371 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts @@ -932,7 +932,7 @@ temperature-sensor@4b { }; eeprom@54 { - compatible = "atmel,24c256"; + compatible = "atmel,24c128"; reg = <0x54>; }; @@ -971,6 +971,11 @@ eeprom@50 { reg = <0x50>; }; + eeprom@54 { + compatible = "atmel,24c64"; + reg = <0x54>; + }; + rtc@6f { compatible = "nuvoton,nct3018y"; reg = <0x6f>;
Add eeprom for yosemite4 use Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> --- arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)