| Message ID | 20231027020703.1231875-1-suhui@nfschina.com |
|---|---|
| State | New |
| Headers | show |
| Series | soc: aspeed: lpc: Fix impossible judgment condition | expand |
On Fri, Oct 27, 2023 at 10:07:04AM +0800, Su Hui wrote: > smatch error： > drivers/soc/aspeed/aspeed-lpc-snoop.c:169 > aspeed_lpc_snoop_config_irq() warn: platform_get_irq() does not return zero > > platform_get_irq() return non-zero IRQ number or negative error code, > change '!lpc_snoop->irq' to 'lpc_snoop->irq < 0' to fix this. > > Fixes: 9f4f9ae81d0a ("drivers/misc: add Aspeed LPC snoop driver") > Signed-off-by: Su Hui <suhui@nfschina.com> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org> regards, dan carpenter
diff --git a/drivers/soc/aspeed/aspeed-lpc-snoop.c b/drivers/soc/aspeed/aspeed-lpc-snoop.c index 773dbcbc03a6..8cb3a0b4692c 100644 --- a/drivers/soc/aspeed/aspeed-lpc-snoop.c +++ b/drivers/soc/aspeed/aspeed-lpc-snoop.c @@ -166,7 +166,7 @@ static int aspeed_lpc_snoop_config_irq(struct aspeed_lpc_snoop *lpc_snoop, int rc; lpc_snoop->irq = platform_get_irq(pdev, 0); - if (!lpc_snoop->irq) + if (lpc_snoop->irq < 0) return -ENODEV; rc = devm_request_irq(dev, lpc_snoop->irq,
smatch error： drivers/soc/aspeed/aspeed-lpc-snoop.c:169 aspeed_lpc_snoop_config_irq() warn: platform_get_irq() does not return zero platform_get_irq() return non-zero IRQ number or negative error code, change '!lpc_snoop->irq' to 'lpc_snoop->irq < 0' to fix this. Fixes: 9f4f9ae81d0a ("drivers/misc: add Aspeed LPC snoop driver") Signed-off-by: Su Hui <suhui@nfschina.com> --- drivers/soc/aspeed/aspeed-lpc-snoop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)