| Message ID | 20220921064309.GA18932@hcl-ThinkPad-T495 |
|---|---|
| State | New |
| Headers | show |
| Series | [v4] ARM: dts: aspeed: yosemit V2: Enable OCP debug card | expand |
> Subject: [PATCH v4] ARM: dts: aspeed: yosemit V2: Enable OCP debug card Please double-check your spelling of commit messages. You've misspelled "yosemite" here, which gives an impression that it is quite likely that other things are wrong with your commit. On Wed, Sep 21, 2022 at 12:13:09PM +0530, Karthikeyan Pasupathi wrote: > Added IPMB-13 channel for Debug Card communication. > which improve the readability of the machine and makes > easier to debug the server. and it will display the some > informations about the server like "system info", > "Critical sensors" and "critical sel". > > --- > --- v4- Resolved syntax error > --- v3- Updated the title and commit > --- v2- Updated the title > --- v1- Initial draft > --- > > Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com> > --- > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts > index 8864e9c312a8..84236df522dc 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts > @@ -215,6 +215,17 @@ > }; > }; > > +&i2c13 { > + status = "okay"; > + // Debug Card > + multi-master; > + ipmb13@10 { > + compatible = "ipmb-dev"; > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; > + i2c-protocol; > + }; > +}; > + > &pwm_tacho { > status = "okay"; > //FSC > -- > 2.17.1 > Reviewed-by: Patrick Williams <patrick@stwcx.xyz>
Will do, thanks! On Sat, Sep 24, 2022 at 3:22 AM Patrick Williams <patrick@stwcx.xyz> wrote: > > > Subject: [PATCH v4] ARM: dts: aspeed: yosemit V2: Enable OCP debug card > > Please double-check your spelling of commit messages. You've misspelled > "yosemite" here, which gives an impression that it is quite likely that > other things are wrong with your commit. > > On Wed, Sep 21, 2022 at 12:13:09PM +0530, Karthikeyan Pasupathi wrote: > > Added IPMB-13 channel for Debug Card communication. > > which improve the readability of the machine and makes > > easier to debug the server. and it will display the some > > informations about the server like "system info", > > "Critical sensors" and "critical sel". > > > > --- > > --- v4- Resolved syntax error > > --- v3- Updated the title and commit > > --- v2- Updated the title > > --- v1- Initial draft > > --- > > > > Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com> > > --- > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts > b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts > > index 8864e9c312a8..84236df522dc 100644 > > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts > > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts > > @@ -215,6 +215,17 @@ > > }; > > }; > > > > +&i2c13 { > > + status = "okay"; > > + // Debug Card > > + multi-master; > > + ipmb13@10 { > > + compatible = "ipmb-dev"; > > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; > > + i2c-protocol; > > + }; > > +}; > > + > > &pwm_tacho { > > status = "okay"; > > //FSC > > -- > > 2.17.1 > > > > Reviewed-by: Patrick Williams <patrick@stwcx.xyz> > > -- > Patrick Williams >
diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts index 8864e9c312a8..84236df522dc 100644 --- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts @@ -215,6 +215,17 @@ }; }; +&i2c13 { + status = "okay"; + // Debug Card + multi-master; + ipmb13@10 { + compatible = "ipmb-dev"; + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; + i2c-protocol; + }; +}; + &pwm_tacho { status = "okay"; //FSC
Added IPMB-13 channel for Debug Card communication. which improve the readability of the machine and makes easier to debug the server. and it will display the some informations about the server like "system info", "Critical sensors" and "critical sel". --- --- v4- Resolved syntax error --- v3- Updated the title and commit --- v2- Updated the title --- v1- Initial draft --- Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com> --- arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 11 +++++++++++ 1 file changed, 11 insertions(+)