| Message ID | 20201215192323.24359-2-hongweiz@ami.com |
|---|---|
| State | New |
| Headers | show |
| Series | net: ftgmac100: Fix AST2600EVB NCSI RX issue | expand |
On Tue, 15 Dec 2020 14:23:23 -0500 Hongwei Zhang wrote: > Fix AST2600 EVB NCSI RX timeout issue by removing FTGMAC100_RXDES0_RX_ERR bit > from macro RXDES0_ANY_ERROR. > > Signed-off-by: Hongwei Zhang <hongweiz@ami.com> Thanks for the patch. Please repost CCing the netdev mailing list so it can be merged to the networking tree (which I assume is your intent). Please also include a Fixes tag pointing to the commit where the timeout issue started (even if it's the first commit of the driver).
On Wed, 16 Dec 2020, at 05:53, Hongwei Zhang wrote: > Fix AST2600 EVB NCSI RX timeout issue by removing FTGMAC100_RXDES0_RX_ERR bit > from macro RXDES0_ANY_ERROR. But why? What is wrong with the EVB that this change resolves? Which revision of the EVB? The change affects all designs using the MAC, not just the AST2600 EVB. Why is this patch an appropriate course of action? Can we not add a quirk targeting the specific board (e.g. a devicetree property)? Andrew
diff --git a/drivers/net/ethernet/faraday/ftgmac100.h b/drivers/net/ethernet/faraday/ftgmac100.h index 63b3e02fab16..734477e6f72f 100644 --- a/drivers/net/ethernet/faraday/ftgmac100.h +++ b/drivers/net/ethernet/faraday/ftgmac100.h @@ -252,7 +252,6 @@ struct ftgmac100_rxdes { /* Errors we care about for dropping packets */ #define RXDES0_ANY_ERROR ( \ - FTGMAC100_RXDES0_RX_ERR | \ FTGMAC100_RXDES0_CRC_ERR | \ FTGMAC100_RXDES0_FTL | \ FTGMAC100_RXDES0_RUNT | \
Fix AST2600 EVB NCSI RX timeout issue by removing FTGMAC100_RXDES0_RX_ERR bit from macro RXDES0_ANY_ERROR. Signed-off-by: Hongwei Zhang <hongweiz@ami.com> --- drivers/net/ethernet/faraday/ftgmac100.h | 1 - 1 file changed, 1 deletion(-)