| Message ID | 20201030055450.29613-1-billy_tsai@aspeedtech.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v2] pinctrl: aspeed: Fix GPI only function problem. | expand |
On Fri, 30 Oct 2020, at 16:24, Billy Tsai wrote: > Some gpio pin at aspeed soc is input only and the prefix name of these > pin is "GPI" only. > This patch fine-tune the condition of GPIO check from "GPIO" to "GPI" > and it will fix the usage error of banks D and E in the AST2400/AST2500 > and banks T and U in the AST2600. > > Fixes: 4d3d0e4272d8 ("pinctrl: Add core support for Aspeed SoCs") > > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> Thanks Billy. Generally the Fixes: tag should be part of the trailer block, hopefully Linus is happy to remove the newline for us! Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
On Fri, Oct 30, 2020 at 6:55 AM Billy Tsai <billy_tsai@aspeedtech.com> wrote: > Some gpio pin at aspeed soc is input only and the prefix name of these > pin is "GPI" only. > This patch fine-tune the condition of GPIO check from "GPIO" to "GPI" > and it will fix the usage error of banks D and E in the AST2400/AST2500 > and banks T and U in the AST2600. > > Fixes: 4d3d0e4272d8 ("pinctrl: Add core support for Aspeed SoCs") > > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> Thanks Billy, patch applied for fixes! Yours, Linus Walleij
diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed.c b/drivers/pinctrl/aspeed/pinctrl-aspeed.c index e03ee78b2434..95c8d400ad59 100644 --- a/drivers/pinctrl/aspeed/pinctrl-aspeed.c +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed.c @@ -286,13 +286,14 @@ int aspeed_pinmux_set_mux(struct pinctrl_dev *pctldev, unsigned int function, static bool aspeed_expr_is_gpio(const struct aspeed_sig_expr *expr) { /* - * The signal type is GPIO if the signal name has "GPIO" as a prefix. + * The signal type is GPIO if the signal name has "GPI" as a prefix. * strncmp (rather than strcmp) is used to implement the prefix * requirement. * - * expr->signal might look like "GPIOT3" in the GPIO case. + * expr->signal might look like "GPIOB1" in the GPIO case. + * expr->signal might look like "GPIT0" in the GPI case. */ - return strncmp(expr->signal, "GPIO", 4) == 0; + return strncmp(expr->signal, "GPI", 3) == 0; } static bool aspeed_gpio_in_exprs(const struct aspeed_sig_expr **exprs)
Some gpio pin at aspeed soc is input only and the prefix name of these pin is "GPI" only. This patch fine-tune the condition of GPIO check from "GPIO" to "GPI" and it will fix the usage error of banks D and E in the AST2400/AST2500 and banks T and U in the AST2600. Fixes: 4d3d0e4272d8 ("pinctrl: Add core support for Aspeed SoCs") Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> --- drivers/pinctrl/aspeed/pinctrl-aspeed.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)