Message ID | 20200603083132.4610-8-tzimmermann@suse.de |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | drm: Convert most CMA-based drivers to GEM object functions | expand |
On Wed, Jun 3, 2020 at 1:31 AM Thomas Zimmermann <tzimmermann@suse.de> wrote: > > The kirin drivers uses drm_gem_cma_dumb_create_internal() for its > .dumb_create implementation. The function is meant for internal use > only by drivers that require additional buffer setup. > > Kirin does not do an additional setup, so convert it over to > drm_gem_cma_dumb_create(). > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Acked-by: Emil Velikov <emil.velikov@collabora.com> > Cc: Xu YiPing <xuyiping@hisilicon.com> > Cc: Rongrong Zou <zourongrong@gmail.com> > Cc: Xinliang Liu <z.liuxinliang@hisilicon.com> Thanks for sending this out! Works fine on my HiKey board. Tested-by: John Stultz <john.stultz@linaro.org> thanks -john
diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c index c339e632522a9..18e57e571e054 100644 --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c @@ -923,7 +923,7 @@ static struct drm_driver ade_driver = { .fops = &ade_fops, .gem_free_object_unlocked = drm_gem_cma_free_object, .gem_vm_ops = &drm_gem_cma_vm_ops, - .dumb_create = drm_gem_cma_dumb_create_internal, + .dumb_create = drm_gem_cma_dumb_create, .prime_handle_to_fd = drm_gem_prime_handle_to_fd, .prime_fd_to_handle = drm_gem_prime_fd_to_handle, .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,