| Message ID | 20190711142457.37028-1-yuehaibing@huawei.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [-next] pinctrl: aspeed: Make aspeed_pinmux_ips static | expand |
On Thu, 11 Jul 2019, at 23:55, YueHaibing wrote: > Fix sparse warning: > > drivers/pinctrl/aspeed/pinmux-aspeed.c:8:12: warning: > symbol 'aspeed_pinmux_ips' was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Andrew Jeffery <andrew@aj.id.au> > --- > drivers/pinctrl/aspeed/pinmux-aspeed.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/aspeed/pinmux-aspeed.c > b/drivers/pinctrl/aspeed/pinmux-aspeed.c > index 5b0fe17..839c01b 100644 > --- a/drivers/pinctrl/aspeed/pinmux-aspeed.c > +++ b/drivers/pinctrl/aspeed/pinmux-aspeed.c > @@ -5,7 +5,7 @@ > > #include "pinmux-aspeed.h" > > -const char *const aspeed_pinmux_ips[] = { > +static const char *const aspeed_pinmux_ips[] = { > [ASPEED_IP_SCU] = "SCU", > [ASPEED_IP_GFX] = "GFX", > [ASPEED_IP_LPC] = "LPC", > -- > 2.7.4 > > >
On Thu, Jul 11, 2019 at 4:25 PM YueHaibing <yuehaibing@huawei.com> wrote: > Fix sparse warning: > > drivers/pinctrl/aspeed/pinmux-aspeed.c:8:12: warning: > symbol 'aspeed_pinmux_ips' was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Patch applied with Andrew's ACK. Yours, Linus Walleij
diff --git a/drivers/pinctrl/aspeed/pinmux-aspeed.c b/drivers/pinctrl/aspeed/pinmux-aspeed.c index 5b0fe17..839c01b 100644 --- a/drivers/pinctrl/aspeed/pinmux-aspeed.c +++ b/drivers/pinctrl/aspeed/pinmux-aspeed.c @@ -5,7 +5,7 @@ #include "pinmux-aspeed.h" -const char *const aspeed_pinmux_ips[] = { +static const char *const aspeed_pinmux_ips[] = { [ASPEED_IP_SCU] = "SCU", [ASPEED_IP_GFX] = "GFX", [ASPEED_IP_LPC] = "LPC",
Fix sparse warning: drivers/pinctrl/aspeed/pinmux-aspeed.c:8:12: warning: symbol 'aspeed_pinmux_ips' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/pinctrl/aspeed/pinmux-aspeed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)