mbox series

[0/4] fsi: Convert to platform remove callback returning void

Message ID cover.1709673414.git.u.kleine-koenig@pengutronix.de
Headers show
Series fsi: Convert to platform remove callback returning void | expand

Message

Uwe Kleine-König March 5, 2024, 9:20 p.m. UTC
Hello,

this series converts all drivers below drivers/fsi to struct
platform_driver::remove_new(). See commit 5c5a7680e67b ("platform:
Provide a remove callback that returns no value") for an extended
explanation and the eventual goal.

All conversations are trivial, because their .remove() callbacks
returned zero unconditionally.

There are no interdependencies between these patches, so they could be
picked up individually. But I'd hope that they get picked up all
together.

Best regards
Uwe

Uwe Kleine-König (4):
  fsi: master-aspeed: Convert to platform remove callback returning void
  fsi: master-ast-cf: Convert to platform remove callback returning void
  fsi: master-gpio: Convert to platform remove callback returning void
  fsi: occ: Convert to platform remove callback returning void

 drivers/fsi/fsi-master-aspeed.c | 6 ++----
 drivers/fsi/fsi-master-ast-cf.c | 6 ++----
 drivers/fsi/fsi-master-gpio.c   | 6 ++----
 drivers/fsi/fsi-occ.c           | 6 ++----
 4 files changed, 8 insertions(+), 16 deletions(-)

base-commit: 11afac187274a6177a7ac82997f8691c0f469e41

Comments

Uwe Kleine-König April 11, 2024, 7:13 a.m. UTC | #1
Hello,

On Tue, Mar 05, 2024 at 10:20:56PM +0100, Uwe Kleine-König wrote:
> this series converts all drivers below drivers/fsi to struct
> platform_driver::remove_new(). See commit 5c5a7680e67b ("platform:
> Provide a remove callback that returns no value") for an extended
> explanation and the eventual goal.
> 
> All conversations are trivial, because their .remove() callbacks
> returned zero unconditionally.
> 
> There are no interdependencies between these patches, so they could be
> picked up individually. But I'd hope that they get picked up all
> together.

I didn't get any feedback on this patch set. As the conversion of
platform_driver::remove depends on these, it would be great if they made
it in during the next merge window.

Best regards
Uwe
Uwe Kleine-König April 29, 2024, 7:21 a.m. UTC | #2
Hello,

On Thu, Apr 11, 2024 at 09:13:38AM +0200, Uwe Kleine-König wrote:
> On Tue, Mar 05, 2024 at 10:20:56PM +0100, Uwe Kleine-König wrote:
> > this series converts all drivers below drivers/fsi to struct
> > platform_driver::remove_new(). See commit 5c5a7680e67b ("platform:
> > Provide a remove callback that returns no value") for an extended
> > explanation and the eventual goal.
> > 
> > All conversations are trivial, because their .remove() callbacks
> > returned zero unconditionally.
> > 
> > There are no interdependencies between these patches, so they could be
> > picked up individually. But I'd hope that they get picked up all
> > together.
> 
> I didn't get any feedback on this patch set. As the conversion of
> platform_driver::remove depends on these, it would be great if they made
> it in during the next merge window.

I intend to change platform_driver::remove soon after the next merge
window to let it cook in next for a while. If this patch set doesn't
make it in before, I'll send it together with the patch changing
platform_driver::remove to Greg.

Best regards
Uwe
Jeremy Kerr April 29, 2024, 7:25 a.m. UTC | #3
Hi Uwe,

> I intend to change platform_driver::remove soon after the next merge
> window to let it cook in next for a while. If this patch set doesn't
> make it in before, I'll send it together with the patch changing
> platform_driver::remove to Greg.


Joel is somewhat-off at present, and the FSI changes typically go
through Greg anyway, so this all sounds fine to me.

In case it helps:

Acked-by: Jeremy Kerr <jk@ozlabs.org>

Cheers,


Jeremy