| Message ID | 20240308021842.1975-1-dorine.a.tipo@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: pct: Convert to dtschema | expand |
On Fri, 08 Mar 2024 02:18:42 +0000, Dorine Tipo wrote: > convert the PCT Arc Performance Counter bindings to DT schema > > Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com> > --- > .../devicetree/bindings/arc/pct.yaml | 36 +++++++++++++++++++ > 1 file changed, 36 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arc/pct.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arc/pct.example.dtb: pmu: 'reg' is a required property from schema $id: http://devicetree.org/schemas/pct.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240308021842.1975-1-dorine.a.tipo@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 08/03/2024 03:18, Dorine Tipo wrote: > convert the PCT Arc Performance Counter bindings to DT schema There is no conversion here! > > Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com> > --- > .../devicetree/bindings/arc/pct.yaml | 36 +++++++++++++++++++ > 1 file changed, 36 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arc/pct.yaml > > diff --git a/Documentation/devicetree/bindings/arc/pct.yaml b/Documentation/devicetree/bindings/arc/pct.yaml > new file mode 100644 > index 000000000000..1f97a7c21b77 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arc/pct.yaml > @@ -0,0 +1,36 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pct.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ARC Performance Counters > + > +maintainers: > + - Vineet Gupta <vgupta@kernel.org> > + - Rob Herring <robh+dt@kernel.org> > + - Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> No, neither me nor Rob have anything to do with Arc. Please choose someone from the ARC maintainers, if there is no specific device maintainer. > + > +description: | > + The ARC700 can be configured with a pipeline performance monitor for counting > + CPU and cache events like cache misses and hits. Like conventional PCT there > + are 100+ hardware conditions dynamically mapped to up to 32 counters > + > +properties: > + compatible: > + const: "snps,arc700-pct" Drop quotes. I have doubts that you tested it. > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false This must be additionalProperties instead. See example schema. > + > +examples: > + - | > + pmu { > + compatible = "snps,arc700-pct"; NAK, test your patches. > Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arc/pct.yaml b/Documentation/devicetree/bindings/arc/pct.yaml new file mode 100644 index 000000000000..1f97a7c21b77 --- /dev/null +++ b/Documentation/devicetree/bindings/arc/pct.yaml @@ -0,0 +1,36 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pct.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ARC Performance Counters + +maintainers: + - Vineet Gupta <vgupta@kernel.org> + - Rob Herring <robh+dt@kernel.org> + - Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> + +description: | + The ARC700 can be configured with a pipeline performance monitor for counting + CPU and cache events like cache misses and hits. Like conventional PCT there + are 100+ hardware conditions dynamically mapped to up to 32 counters + +properties: + compatible: + const: "snps,arc700-pct" + + reg: + maxItems: 1 + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + pmu { + compatible = "snps,arc700-pct"; + };
convert the PCT Arc Performance Counter bindings to DT schema Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com> --- .../devicetree/bindings/arc/pct.yaml | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/arc/pct.yaml -- 2.25.1