| Message ID | 20200914114651.105219-1-fazilyildiran@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | arc: plat-hsdk: fix kconfig dependency warning when !RESET_CONTROLLER | expand |
On 9/14/20 4:46 AM, Necip Fazil Yildiran wrote: > When ARC_SOC_HSDK is enabled and RESET_CONTROLLER is disabled, it results > in the following Kbuild warning: > > WARNING: unmet direct dependencies detected for RESET_HSDK > Depends on [n]: RESET_CONTROLLER [=n] && HAS_IOMEM [=y] && (ARC_SOC_HSDK [=y] || COMPILE_TEST [=n]) > Selected by [y]: > - ARC_SOC_HSDK [=y] && ISA_ARCV2 [=y] > > The reason is that ARC_SOC_HSDK selects RESET_HSDK without depending on or > selecting RESET_CONTROLLER while RESET_HSDK is subordinate to > RESET_CONTROLLER. > > Honor the kconfig menu hierarchy to remove kconfig dependency warnings. > > Fixes: a528629dfd3b ("ARC: [plat-hsdk] select CONFIG_RESET_HSDK from Kconfig") > Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com> Applied to for-curr Thx, -Vineet > --- > arch/arc/plat-hsdk/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arc/plat-hsdk/Kconfig b/arch/arc/plat-hsdk/Kconfig > index ce8101834518..6b5c54576f54 100644 > --- a/arch/arc/plat-hsdk/Kconfig > +++ b/arch/arc/plat-hsdk/Kconfig > @@ -8,5 +8,6 @@ menuconfig ARC_SOC_HSDK > select ARC_HAS_ACCL_REGS > select ARC_IRQ_NO_AUTOSAVE > select CLK_HSDK > + select RESET_CONTROLLER > select RESET_HSDK > select HAVE_PCI
diff --git a/arch/arc/plat-hsdk/Kconfig b/arch/arc/plat-hsdk/Kconfig index ce8101834518..6b5c54576f54 100644 --- a/arch/arc/plat-hsdk/Kconfig +++ b/arch/arc/plat-hsdk/Kconfig @@ -8,5 +8,6 @@ menuconfig ARC_SOC_HSDK select ARC_HAS_ACCL_REGS select ARC_IRQ_NO_AUTOSAVE select CLK_HSDK + select RESET_CONTROLLER select RESET_HSDK select HAVE_PCI
When ARC_SOC_HSDK is enabled and RESET_CONTROLLER is disabled, it results in the following Kbuild warning: WARNING: unmet direct dependencies detected for RESET_HSDK Depends on [n]: RESET_CONTROLLER [=n] && HAS_IOMEM [=y] && (ARC_SOC_HSDK [=y] || COMPILE_TEST [=n]) Selected by [y]: - ARC_SOC_HSDK [=y] && ISA_ARCV2 [=y] The reason is that ARC_SOC_HSDK selects RESET_HSDK without depending on or selecting RESET_CONTROLLER while RESET_HSDK is subordinate to RESET_CONTROLLER. Honor the kconfig menu hierarchy to remove kconfig dependency warnings. Fixes: a528629dfd3b ("ARC: [plat-hsdk] select CONFIG_RESET_HSDK from Kconfig") Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com> --- arch/arc/plat-hsdk/Kconfig | 1 + 1 file changed, 1 insertion(+)