From patchwork Mon Aug 27 14:38:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugeniy Paltsev X-Patchwork-Id: 962543 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=synopsys.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S8qOVJW/"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=synopsys.com header.i=@synopsys.com header.b="Uz8P+fE/"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41zZKd3qzJz9s1c for ; Tue, 28 Aug 2018 00:39:49 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=d/3cPYIoAkUkaskb0J3dPDtF013uBR64+PgrtMPCfHY=; b=S8q OVJW/w+JbsqZP10FFehypdkNM2vUL9UDR153T2h9ZwpPoVhWKh3ZU3esigxWA7TbjED7fIBoXc5kk Mx503K3o7cwaGM7n1dVXRhK6lXTHCNI3nC5pEj72mrhF1veuOBHa5C0k3Ez3TTVQ8LyuQe7jl6rMw G/ikk+ofNl36Ivg932FpVprCqowJlLCUbcwB8WEeUw3io1ytN2v78Vo5fRt0DkdH8UeAlzmY0694Z cql2lIlLyKFinupIPaE8fdW/i/wHYoHlGDjvXTia5g7N/Xu8cBS7J4BcSNZ2iEVulfmtHZFoMXHFa F9yurGoaoBVZkzzBcqWmaojZB8uYswQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fuIgC-0007xu-2V; Mon, 27 Aug 2018 14:39:44 +0000 Received: from smtprelay.synopsys.com ([198.182.60.111]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fuIes-000756-MU for linux-snps-arc@lists.infradead.org; Mon, 27 Aug 2018 14:38:38 +0000 Received: from mailhost.synopsys.com (mailhost1.synopsys.com [10.12.238.239]) by smtprelay.synopsys.com (Postfix) with ESMTP id 53ED910C1653; Mon, 27 Aug 2018 07:38:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1535380689; bh=q3YqdrjAJZNRdEQQIlBP0LhqGoSbVJw0DCfhY77+6fk=; h=From:To:Cc:Subject:Date:From; b=Uz8P+fE/sB5SsoQD8hceADdrJJSp2Bh2Ne4c2X0USfD47mfhJNd3EuqqDybRVzkcT 5LOa2gtbbbkW3NeVgSS3sEmsskuA01H8jxTJaqq7dRH7S5UHSGKHeUd8csZc0YEY9p /UpG2VqrDeofwWgKEBiYfby+fKZVMuUpUmwjLMvabXm6yalQ6IhL4dCNP5hHKF2H0r kzy5dno4+gMZftaX6Dx9WUJUwiB9/OnMGBY/rOziPvEc4kcpC2b/4X/UOy2aKH48pm sZ+iaN3I+I++uKxluCnUib31HoNKDMAVj4hG2/WGy+uYaNmVCBNr95BZwpCByZ+bP5 oEXa52Pca+zyw== Received: from paltsev-e7480.internal.synopsys.com (paltsev-e7480.internal.synopsys.com [10.121.3.36]) by mailhost.synopsys.com (Postfix) with ESMTP id B3E8755E0; Mon, 27 Aug 2018 07:38:06 -0700 (PDT) From: Eugeniy Paltsev To: Philipp Zabel Subject: [PATCH] ARC: HSDK: improve reset driver Date: Mon, 27 Aug 2018 17:38:03 +0300 Message-Id: <20180827143803.28178-1-Eugeniy.Paltsev@synopsys.com> X-Mailer: git-send-email 2.14.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180827_073823_232610_F0061DD4 X-CRM114-Status: UNSURE ( 8.84 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [198.182.60.111 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eugeniy Paltsev , linux-snps-arc@lists.infradead.org, Alexey Brodkin , linux-kernel@vger.kernel.org MIME-Version: 1.0 Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org As for today HSDK reset driver implements only .reset() callback. In case of driver which implements one of standard reset controller usage pattern (call *_deassert() in probe(), call *_assert() in remove()) that leads to inoperability of this reset driver. Improve HSDK reset driver by calling .reset() callback inside of .assert()/.deassert() callbacks to avoid each reset controller user adaptation for work with both reset methods (reset() and .assert()/.deassert() pair) Signed-off-by: Eugeniy Paltsev --- drivers/reset/reset-hsdk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/reset/reset-hsdk.c b/drivers/reset/reset-hsdk.c index 8bce391c6943..1fd91df91343 100644 --- a/drivers/reset/reset-hsdk.c +++ b/drivers/reset/reset-hsdk.c @@ -86,6 +86,8 @@ static int hsdk_reset_reset(struct reset_controller_dev *rcdev, static const struct reset_control_ops hsdk_reset_ops = { .reset = hsdk_reset_reset, + .assert = hsdk_reset_reset, + .deassert = hsdk_reset_reset, }; static int hsdk_reset_probe(struct platform_device *pdev)