From patchwork Mon Apr 17 16:13:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Brodkin X-Patchwork-Id: 751398 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3w6CxT6B38z9ryk for ; Tue, 18 Apr 2017 02:13:49 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nDIGwX/O"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=FX4G5SUgFazGGx8QjAdHUa56aFx56QL/gcuLkVtv2g4=; b=nDI GwX/O/VvVULe1gv2EJX4qc0x/0g47UX3tpI7F1nh3bcheh4VNMQe3NW0aWdpfrBZ9MFWg6gcIHyhH 74tw59YqjvZPg59VWS0MZ1sjwRnjO/SxpFDnYejxjCoZj6QDK/7A1Mu/UGgxefAA4ZMEOhVytaGvG mFO5gV6+5wDpHL0PguC3YhhBRmqBrRokIlElxSEdmHdy/6N/ZWg1OAXc0EDkvC1ChSv3VBwNpCFPE GZIWKCqrdWAi0kQ1f3NJGqQ8Hyky+KOk3KDS2avfhTRXTpKE8wOrsl+fyalHzCPFiWsqREd+xSC6g mxIzrbv7hxxoZayyAYj7Dm8JlvFG3Zw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1d09Hg-0004IG-3n; Mon, 17 Apr 2017 16:13:48 +0000 Received: from smtprelay.synopsys.com ([198.182.60.111]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1d09Hd-0004GU-3E for linux-snps-arc@lists.infradead.org; Mon, 17 Apr 2017 16:13:46 +0000 Received: from mailhost.synopsys.com (mailhost2.synopsys.com [10.13.184.66]) by smtprelay.synopsys.com (Postfix) with ESMTP id 9223710C08E9; Mon, 17 Apr 2017 09:13:23 -0700 (PDT) Received: from mailhost.synopsys.com (localhost [127.0.0.1]) by mailhost.synopsys.com (Postfix) with ESMTP id 31D7C34E; Mon, 17 Apr 2017 09:13:23 -0700 (PDT) Received: from abrodkin-7440l.internal.synopsys.com (unknown [10.121.8.101]) by mailhost.synopsys.com (Postfix) with ESMTP id 4E832346; Mon, 17 Apr 2017 09:13:20 -0700 (PDT) From: Alexey Brodkin To: u-boot@lists.denx.de Subject: [PATCH] ehci-ppc4xx: Prepare for usage of readl()/writel() accessors Date: Mon, 17 Apr 2017 19:13:17 +0300 Message-Id: <1492445597-32034-1-git-send-email-abrodkin@synopsys.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170417_091345_143856_277C5570 X-CRM114-Status: UNSURE ( 5.89 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [198.182.60.111 listed in list.dnswl.org] -0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Tom Rini , linux-snps-arc@lists.infradead.org, Alexey Brodkin , Stefan Roese MIME-Version: 1.0 Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org We used to have opencoded ehci_readl()/writel() which required no external functions to be called. Now with attempt to switch to generic readl()/writel() accessors we see a missing declaration of those accessors in ehci-ppc4xx. Something like that happens if applied http://patchwork.ozlabs.org/patch/726714/: ---------------->8--------------- CC drivers/usb/host/ehci-ppc4xx.o drivers/usb/host/ehci-ppc4xx.c: In function 'ehci_hcd_init': drivers/usb/host/ehci-ppc4xx.c:23:3: warning: implicit declaration of function 'readl' [-Wimplicit-function-declaration] HC_LENGTH(ehci_readl(&(*hccr)->cr_capbase))); ^ ---------------->8--------------- Signed-off-by: Alexey Brodkin Cc: Tom Rini Cc: Marek Vasut Cc: Stefan Roese Reviewed-by: Stefan Roese --- drivers/usb/host/ehci-ppc4xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ehci-ppc4xx.c b/drivers/usb/host/ehci-ppc4xx.c index 9aee3ff786cb..9d235776428e 100644 --- a/drivers/usb/host/ehci-ppc4xx.c +++ b/drivers/usb/host/ehci-ppc4xx.c @@ -8,6 +8,7 @@ */ #include #include +#include #include "ehci.h"