From patchwork Wed Aug 17 06:23:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liav Rehana X-Patchwork-Id: 659924 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3sDfNB5sL3z9t0X for ; Wed, 17 Aug 2016 16:24:58 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b=mQyg2tKE; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bZuHZ-0004bV-48; Wed, 17 Aug 2016 06:24:57 +0000 Received: from mail-eopbgr00042.outbound.protection.outlook.com ([40.107.0.42] helo=EUR02-AM5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bZuHV-0004SB-Le for linux-snps-arc@lists.infradead.org; Wed, 17 Aug 2016 06:24:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=A41h91juA5ACQuW+ADOZr5PN9N4HNEcrTvJSBDgqXEk=; b=mQyg2tKEpz/fVV+gdS+NC2wDbkNoU/TACv4Er4/o5bRnECdVqA298ebUZYIFiBg+TDdeD56QKI1Ak0occX0d68RRo8LmDi8h4baONONVGP81qudyZ2rM/z7QM8H7lbMlnz+eDvqvuuzuLT6EE2Up7KjKsErLTA5Rwfmk1HTa5sc= Received: from AM4PR0501CA0013.eurprd05.prod.outlook.com (2603:10a6:200:6::23) by AM3PR05MB402.eurprd05.prod.outlook.com (2a01:111:e400:880e::14) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.544.10; Wed, 17 Aug 2016 06:24:29 +0000 Received: from AM1FFO11FD010.protection.gbl (2a01:111:f400:7e00::194) by AM4PR0501CA0013.outlook.office365.com (2603:10a6:200:6::23) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.587.9 via Frontend Transport; Wed, 17 Aug 2016 06:24:29 +0000 Authentication-Results: spf=pass (sender IP is 193.47.165.134) smtp.mailfrom=mellanox.com; synopsys.com; dkim=none (message not signed) header.d=none; synopsys.com; dmarc=pass action=none header.from=mellanox.com; Received-SPF: Pass (protection.outlook.com: domain of mellanox.com designates 193.47.165.134 as permitted sender) receiver=protection.outlook.com; client-ip=193.47.165.134; helo=mtlcas13.mtl.com; Received: from mtlcas13.mtl.com (193.47.165.134) by AM1FFO11FD010.mail.protection.outlook.com (10.174.65.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.567.7 via Frontend Transport; Wed, 17 Aug 2016 06:24:30 +0000 Received: from MTLCAS13.mtl.com (10.0.8.78) by mtlcas13.mtl.com (10.0.8.78) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Wed, 17 Aug 2016 09:24:29 +0300 Received: from MTLCAS01.mtl.com (10.0.8.71) by MTLCAS13.mtl.com (10.0.8.78) with Microsoft SMTP Server (TLS) id 15.0.1178.4 via Frontend Transport; Wed, 17 Aug 2016 09:24:29 +0300 Received: from ezex10.ezchip.com (10.0.13.1) by MTLCAS01.MTL.COM (10.0.8.71) with Microsoft SMTP Server (TLS) id 14.3.301.0; Wed, 17 Aug 2016 09:23:59 +0300 Received: from localhost.localdomain (10.1.3.132) by ezex10.ezchip.com (10.1.1.4) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 17 Aug 2016 09:23:59 +0300 From: Liav Rehana To: Subject: [PATCH] ARC: Change ld.as instruction to regular ld. Date: Wed, 17 Aug 2016 09:23:57 +0300 Message-ID: <1471415037-14544-1-git-send-email-liavr@mellanox.com> X-Mailer: git-send-email 1.7.1 MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.000.1202-22518.005 X-TM-AS-Result: No--6.547100-8.000000-31 X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No Received-SPF: None (MTLCAS01.mtl.com: liavr@mellanox.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:193.47.165.134; IPV:NLI; CTRY:IL; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(189002)(199003)(33646002)(11100500001)(50466002)(586003)(189998001)(4326007)(106466001)(49486002)(229853001)(626004)(2351001)(87936001)(4001430100002)(92566002)(107886002)(110136002)(8676002)(305945005)(8936002)(7846002)(36756003)(48376002)(47776003)(2906002)(86362001)(356003)(19580395003)(50226002)(50986999)(81156014)(19580405001)(81166006)(5003940100001)(77096005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR05MB402; H:mtlcas13.mtl.com; FPR:; SPF:Pass; PTR:mail13.mellanox.com; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; AM1FFO11FD010; 1:yAmo3KPmqGAO8+brjyl8X1Kvjvf7x+eMp1AdPManD9S1/fYIGuhLPbYklZJ8pOXkSHgjJM6j4RTBwSeJo6U0BWuGGDgpHqZSw7RhNasXO2hLDEUB5QKix7CZOi3Prsg8XvwsuTOBautqgA7tJkDgGzRTti7WvSTPkzzFJPG2XV7RGqHKfuf9ZvjTaHxt65gbqVSFW6dztKli+/4V2/SMt8UZgBLsplpq0KQjxPKyqE6saGxvnW4o0BK1UiHSLs8PPQ+0NvFyN/AEPxqU7i2TpiHZW2dtJKrI97I3n3a/7zEtcm0825qKY2JEZ84AIlagmOfdhFYxomg6PPv9K9C5hgE1sJ/6p+LqcMR+MqGb8nxkyIEgWOA9ElamjxHLIbg+nZuo2pAHY5aSzqXY8RU6Xy64n2C4dKCM4CaWancMiZKD0R0k+cEhd0sgyNEQkbbbfnOm4iBh7E3KcuHZUCE7G5CdtrviTgGyHErtySZv6lIPZ7cKOtP/UV7x1yeZENjp X-MS-Office365-Filtering-Correlation-Id: 49abe102-7447-4297-22a7-08d3c6672590 X-Microsoft-Exchange-Diagnostics: 1; AM3PR05MB402; 2:+/wJ8hH72/vGFXxpnIKFxf2+HaUsm+QC15TNv0vJSNJOcLzMN34INa0AOAWGXCWlTBSSoYkWY/qzCEcyCFrmoOhFQJ3rZodspMysc+cVPmtBPispXrzgmUWbNe25asCy2M+OodeD9EiS7TjT4GaNU5QQzH00GL1m+G3Ji046eJPyC9+Wr3x/Lb6RD0v0mCsJ; 3:+andpeqatoXlBrWwsIbNwTvHegRCEH/53pfuW7oaOwTQoGO/cO57BwLyaVbB/dUXDEF+MPA21G1aK0wOQ/k5xSkrbjaYgTC+IXQtpysmfxx0FRn2A2wfR2uLPu2OG8pWnkUSIb6RqTpJlW0yZZsnefKbGcmcw2iKiDnz50kZLHh+QGGRg0Wp9D7QMJ1t+WLfUgezQjQ0cLSoE49ixtx1GmU1NhyZqOcZazxABX9wDMaIM1DvwKbxnolf60tr4s5p3qSUQqmi3zuDYHF/RGeGRA==; 25:PKQ98jitKCQcbzbHSYJZ9o6ER5OrZYjAwCuOuc20L6bLuvIkAh4k8W4k6h801BTbI/teU5St/1gwLn/XYU13rCvJAgu6ZcPNnE1AgfSwqARqThyICw4E3QZOPLwQO1qWQ4uDc9Wm3MrXJ6xBpyQcLuPGHW0D6vP6oEDaA/lQ5YAmlXWB2z7L14F1SLeEXpopQ7asUtgzmClRkuqpmJygnUvg5nRNHKtrJnl64brX5HCkqljkQY7ztRmA+0OA051bnIcd4cmSbkR/AjSThbNONfOJKYBHIoQexR3ZJm0LGJHvtf0UjOu8ysmpR8oFnJ3NHxMZaoYmvbEXELFQApU8nxxfIyi1H4XWy0p3prMYI12SkrIPW3KMi2LYV3YcmjkFCgLiz55vesddkiI4oUfEAoFQ+XvbLJSFb2xQrM0qpXo= X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(8251501002); SRVR:AM3PR05MB402; X-Microsoft-Exchange-Diagnostics: 1; AM3PR05MB402; 31:CRRE6xVXszQ3viCsAQKLeZ/z2Oi/rAGSnHxwnQNJ0YBqGcijpGzJU0UJz6UJetwhApFDz0pmFeund6bRSeF+vSigBMwP+P4JCIV0sY3cbB6NlD5OY6/vmwigigeu2H8lpCBLdoXt/FocbIjb3C5felGsscNqy7/cUCMLQeZqKu0y2e9N7ndyvu8xAyXgWVPg0z3UWrFs+cPOCcWa4KXj40DJwpL81GHPhE6d+D5Tt80=; 20:zrBpQ3xfB6+A0ehuRNev3/O/rCJlpcXiOF/qd3aLLuwZG0Qcwmf3qRGRmp5SgCwz3yxJsbAKRP5jnfPJMr4o2Cq+lXcWr8ENAs7CcSPMVJS/J/fSDn4oGJZzddxmyvvmMRgs3A5DxWhlKZDtPxdvxho0n/nvVg22OUdNtwi8yNOoCGvzEAo6kMmr8lSSk85Ckok6s3cCKSGSOY4Ne6l66cKg9/WEzTnWgfK0NMq7r94ts1yglgTU5STSEjFkKSmznNawfZgGPdnmuGGpZG7f4oNirUhG7KsBsqFXPyeg36AzSer6lfXxy6F/B4q6ChEnb2FNHmE/p30cRS3O+IBzSdh/IEeonmmjzun1flb+N44sEKSY5cfnSU7zJS4dy1NRxCYF7zF1UI95FxpfISbI1r/YJqjGlJoLOLwWj3gBRpmlTNzjNtuxDB6sjDM+Buzfi/OwvfL6jeW3Vfa0Yx9SIVo8+S+d8GD7lUGG37tgKpxl7Q1s8OFQUBe0Nrcx55C3 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13016025)(8121501046)(13018025)(5005006)(10201501046)(3002001)(6055026); SRVR:AM3PR05MB402; BCL:0; PCL:0; RULEID:; SRVR:AM3PR05MB402; X-Microsoft-Exchange-Diagnostics: 1; AM3PR05MB402; 4:cWozn0TcfH1Ua7VrOsUBu9HDBSceiHwBhcqEvYJp9cUJP5/4dIatgo96OSrVWtsoD5uV0Fh5/LN25cs0M50pFpmuq8BXM+NpgX+xDviM5RQyuL98pVW3iboka31eePoyTHe1HNBlY300FW9xCoVWQKy7I7L7AWk+9pu/NhKMjFq7CvO1Q6mM2w6BIHgJ0IavgrgJ7Y9c9v5bJGTAd3/AHzraNE3sKyhA69Vkn2h229C6i3ey+d8pWy+hlCm3r3Jn7HYwhwuBBkE2j2BR4NJZ5HAd2lnULybJJEGPv9dt6RKj6YSKHzXo9ST1bt7SsVxEKgy2iydDONR1F+fRupeMnt21rr91kYFdgvJdT7+auEL0e8lamvQ/6mCZQZlf/56T1KIt7uZc85LL9XIyXEfowetxitfSatZ+tRy5cjvK7oZjMFjpsxSofoqBcYUM3nUu X-Forefront-PRVS: 0037FD6480 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM3PR05MB402; 23:JuVUKc8U8KQt3IYDlS1L346kUIbOJDV/29Z+MZv37V?= =?us-ascii?Q?gBZFEvKTjRQYSi4BlFRklqtoYGpO1r2ZMSM9IbLTQTUAgjWXk2F1pAR5Hcjd?= =?us-ascii?Q?YCGz2mG1JdfeUkUp/0IrX+ymNe6wUwsvA3UjiLMdgNhxX5PQjIm56yLHrL9D?= =?us-ascii?Q?QwyEQB1GnR48dnT4jL7wrp1+Wkfvq85k0wC4rrj0ulk2ZBT8AElOt/qylZE0?= =?us-ascii?Q?ffNONt4cdNDUdk8sLNMG86GKKu6gg1z+ar60A6O1oJ+1cfk2m3a1oS+d2YNb?= =?us-ascii?Q?vTnphKeMPYFCZ0Xo5LbwmtY3ssGl1iglDRUhPfblMi2ABEmGcvy4L5NSeUan?= =?us-ascii?Q?drqiYCuBNradte4E5Cqm9MPh2sCOEJ+yeCHK7uC+WVu31srvqtXQPTSvbqfx?= =?us-ascii?Q?LNfBsZ29AA5lEGRjXMznUa5CmRR65C1GfJgXM/RSKY+aSGBdFpQd2O+o18xM?= =?us-ascii?Q?zISHkhIx3yrPssbVC0Dh0C4Cj39rKHGO5jP1UEuonBm+Vf/K3dQ+fCpj9D+p?= =?us-ascii?Q?7TPWtlCGHHeNXCbi0XbOTiS7pHe5VBQEUJUfNZogc0mH7Z1YPP5N6w/kGwAx?= =?us-ascii?Q?N0P1MoEtU5qvUOqjBGlwQsHYImTRIHihxd2ZnF77oKNYF+p+v/2MpSgLvzx5?= =?us-ascii?Q?ggzelfTYTsbDN46kxAyOcE7aF/q3R0IArWwC3Drb8m7kbcztBrRH+vhKqLuo?= =?us-ascii?Q?8jfJf1DumUi/5ALQR6CDASursuKci4FvS414t4OCtXkRcV//yNCQz8InMj8Y?= =?us-ascii?Q?Y8XgOannv1XOBRbEpNapsXB2IV2YpUMLOOvSkZN+khTG1e5Jz7rGbBLndv/r?= =?us-ascii?Q?6UpMtjRQsx80IH4xPOpixd0xd1cHcKD8JtTkqBNyJIteMPE9kwLMppyGwmma?= =?us-ascii?Q?MvOdjcsxLJ5qsAFKRBVKeBQkusEQc/Sk0FtJj2vavef78iWEcqEyuW8iUDXH?= =?us-ascii?Q?ueqa4FphKFaJS6oFOiNHkRGYb5FS7oDxpWQBu1Cvx/44UPiSP73dZgWckNEw?= =?us-ascii?Q?cl9uodD7HN9GwblWyzHevdESYgcJXKPpTI2gzn0yT7Yg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; AM3PR05MB402; 6:B2E7uK785ZFMgcJoOtNHc3KNSbYhu2h0WaB1YEn0VmLUwOUGDtcN5fl9avvXv+cXY5QXIPqbwwZJIPjgoCWMV0wlDEcJUkRPauqFskVn8aE/UQW+WmiFg+X26t/e2FBuUs93HPyujQvcZ73RwXvZSWypxyHXxtPun4QS/nkPiKwsQ//ovv73zBEyRL8JfL6HrO0P2v/XXAuiEORbOKahozvcE/X8rrjLrYXIEqbAU2bte2S1tO2l8rQthd1awkBmImkoVH+F1GLgmw0k2LSZsyYowawtq5l9lyvsiBukP6Xcni/7PbVrRPWtLeufbzmV5ZI9lKz25DQCCFXvZ3bUvQ==; 5:hKSVBFV/x45xNek6aLrYLCZENF5k1uCBNczCmJPm5JFRPnWXJND28ORd9+ZgH3Obz+Q1OfsynSitB53cpHO/LliCYFtqAg9CZ91kxe+CEKQgRN2Sp0yizUu96YHGyhU5MtgArdhqGuomyxlIGaw29A==; 24:i6wLHhL1DdvltHNlZfx1FUFZng0/t6EgHj74Pq3Rxg8ZSw92yNrzu8lLFnjcBGoiCsiuTCOkEgfOBb0zPBHUUawIjHjtx5aVJOt76CpWY90=; 7:/vjH8RGeGNMYWelLGAHc0jmlDHuvnAH3Rh38SRUuY1DVlnEllOJyxb9r3zVzro/zgv29Rt+nnQERJb8x8OcHsLEIASZpogn8MABECAAgK61WV5/eKztcKuIkG0VD1T231oF38/9YTZqhRXb3K/81FxaAHGYG/e/PXYv2iaty018Kefo8hwpgBXhFTZbSjdLMNHo5zxkWODfhZiDW6x06oPxRkCj/ZVGdfroHY4f3uO+LD4GaupjfNZlEpGXt9Oon SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2016 06:24:30.1946 (UTC) X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b; Ip=[193.47.165.134]; Helo=[mtlcas13.mtl.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR05MB402 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160816_232454_138134_7D36F4CB X-CRM114-Status: UNSURE ( 7.72 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [40.107.0.42 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [40.107.0.42 listed in wl.mailspike.net] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: noamca@mellanox.com, Vineet.Gupta1@synopsys.com, linux-kernel@vger.kernel.org, Liav Rehana , linux-snps-arc@lists.infradead.org, eladkan@mellanox.com Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Liav Rehana User mode callee regs are explicitly collected before signal delivery or breakpoint trap. r25 is special for kernel as it serves as task pointer, so user mode value is clobbered very early. It is saved in pt_regs where generally only scratch (caller saved) res are saved. The code to access the corresponding pt_regs location had a subtle bug as it was using load/store with scaling of offset, whereas the offset was already byte wise correct. So fix this by replacing LD.AS with a standard LD Signed-off-by: Liav Rehana Tested-by: Alexey Brodkin --- arch/arc/include/asm/entry.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arc/include/asm/entry.h b/arch/arc/include/asm/entry.h index 337ab6d..9d8f85d 100644 --- a/arch/arc/include/asm/entry.h +++ b/arch/arc/include/asm/entry.h @@ -138,7 +138,7 @@ #ifdef CONFIG_ARC_CURR_IN_REG ; Retrieve orig r25 and save it with rest of callee_regs - ld.as r12, [r12, PT_user_r25] + ld r12, [r12, PT_user_r25] PUSH r12 #else PUSH r25 @@ -194,7 +194,7 @@ ; SP is back to start of pt_regs #ifdef CONFIG_ARC_CURR_IN_REG - st.as r12, [sp, PT_user_r25] + st r12, [sp, PT_user_r25] #endif .endm