| Message ID | 4137018.dRCyAxMCAD@tool |
|---|---|
| State | Changes Requested |
| Delegated to: | Jonas Gorski |
| Headers | show |
On 16 August 2016 at 13:47, Daniel Gonzalez Cabanelas <dgcbueu@gmail.com> wrote: > Fix the DTS file for the Livebox 1 routers: > - leds are totally wrong, fix them. > - no failsafe button, use button 1 for this purpose > - part probe wrong, it should be RedBoot (uppercase matters) > > Signed-off-by: Daniel Gonzalez Cabanelas <dgcbueu@gmail.com> > diff --git a/target/linux/brcm63xx/dts/livebox-blue-5g.dts b/target/linux/brcm63xx/dts/livebox-blue-5g.dts It seems Daniel uses a proper "From" e-mail header now: "From: Daniel Gonzalez Cabanelas <dgcbueu@gmail.com>" Yet, patchwork doesn't seem to respect it, see: https://patchwork.ozlabs.org/patch/659682/ "Submitted by dani on Aug. 16, 2016, 11:47 a.m." My guess is patchwork stored name from some old Danile's submissions which got: From: dani <dgcbueu@gmail.com> How can we tell patchwork to use current name for these and further patches?
On 22 August 2016 at 08:48, Rafał Miłecki <zajec5@gmail.com> wrote: > On 16 August 2016 at 13:47, Daniel Gonzalez Cabanelas <dgcbueu@gmail.com> wrote: >> Fix the DTS file for the Livebox 1 routers: >> - leds are totally wrong, fix them. >> - no failsafe button, use button 1 for this purpose >> - part probe wrong, it should be RedBoot (uppercase matters) >> >> Signed-off-by: Daniel Gonzalez Cabanelas <dgcbueu@gmail.com> >> diff --git a/target/linux/brcm63xx/dts/livebox-blue-5g.dts b/target/linux/brcm63xx/dts/livebox-blue-5g.dts > > It seems Daniel uses a proper "From" e-mail header now: > "From: Daniel Gonzalez Cabanelas <dgcbueu@gmail.com>" > > Yet, patchwork doesn't seem to respect it, see: > https://patchwork.ozlabs.org/patch/659682/ > "Submitted by dani on Aug. 16, 2016, 11:47 a.m." > > My guess is patchwork stored name from some old Danile's submissions which got: > From: dani <dgcbueu@gmail.com> > > How can we tell patchwork to use current name for these and further patches? There is a commit in the git for patchwork that it will always use name from the newest email sent, but it is currently missing in the running instance. I emailed Jeremy and he updated Daniel's name and will look into integrating the commit into the patchwork instance. Jonas
Hi Daniel, On 16 August 2016 at 13:47, Daniel Gonzalez Cabanelas <dgcbueu@gmail.com> wrote: > Fix the DTS file for the Livebox 1 routers: > - leds are totally wrong, fix them. > - no failsafe button, use button 1 for this purpose > - part probe wrong, it should be RedBoot (uppercase matters) These are still three different things, please split it accordingly. > Signed-off-by: Daniel Gonzalez Cabanelas <dgcbueu@gmail.com> > diff --git a/target/linux/brcm63xx/dts/livebox-blue-5g.dts b/target/linux/brcm63xx/dts/livebox-blue-5g.dts > index 0df5fa8..6eeba69 100644 > --- a/target/linux/brcm63xx/dts/livebox-blue-5g.dts > +++ b/target/linux/brcm63xx/dts/livebox-blue-5g.dts > @@ -23,7 +23,7 @@ > button1 { Please update the node name as well. > label = "BTN_1"; > gpios = <&gpio1 4 1>; > - linux,code = <BTN_1>; > + linux,code = <KEY_RESTART>; > }; > > button2 { > @@ -37,28 +37,28 @@ > compatible = "gpio-leds"; > > red_adsl_fail { > - label = "Livebox-blue-5g:red:adsl-fail"; > + label = "Livebox1:red:adsl-fail-power"; > gpios = <&gpio0 0 0>; > default-state = "on"; > }; > > red_adsl { > - label = "Livebox-blue-5g:red:adsl-fail"; > + label = "Livebox1:red:adsl"; > gpios = <&gpio0 1 0>; > }; > > red_traffic { > - label = "Livebox-blue-5g:red:adsl-fail"; > + label = "Livebox1:red:traffic"; > gpios = <&gpio0 2 0>; > }; > > red_phone { > - label = "Livebox-blue-5g:red:adsl-fail"; > + label = "Livebox1:red:phone"; > gpios = <&gpio0 3 0>; > }; > > red_wifi { > - label = "Livebox-blue-5g:red:adsl-fail"; > + label = "Livebox1:red:wifi"; > gpios = <&gpio0 4 0>; Oops, looks like a clear c&p fail by me. > }; > }; > @@ -68,5 +68,5 @@ > reg = <0x1e400000 0x800000>; > status = "ok"; > > - linux,part-probe = "redboot"; > + linux,part-probe = "RedBoot"; > }; Regards Jonas
diff --git a/target/linux/brcm63xx/dts/livebox-blue-5g.dts b/target/linux/brcm63xx/dts/livebox-blue-5g.dts index 0df5fa8..6eeba69 100644 --- a/target/linux/brcm63xx/dts/livebox-blue-5g.dts +++ b/target/linux/brcm63xx/dts/livebox-blue-5g.dts @@ -23,7 +23,7 @@ button1 { label = "BTN_1"; gpios = <&gpio1 4 1>; - linux,code = <BTN_1>; + linux,code = <KEY_RESTART>; }; button2 { @@ -37,28 +37,28 @@ compatible = "gpio-leds"; red_adsl_fail { - label = "Livebox-blue-5g:red:adsl-fail"; + label = "Livebox1:red:adsl-fail-power"; gpios = <&gpio0 0 0>; default-state = "on"; }; red_adsl { - label = "Livebox-blue-5g:red:adsl-fail"; + label = "Livebox1:red:adsl"; gpios = <&gpio0 1 0>; }; red_traffic { - label = "Livebox-blue-5g:red:adsl-fail"; + label = "Livebox1:red:traffic"; gpios = <&gpio0 2 0>; }; red_phone { - label = "Livebox-blue-5g:red:adsl-fail"; + label = "Livebox1:red:phone"; gpios = <&gpio0 3 0>; }; red_wifi { - label = "Livebox-blue-5g:red:adsl-fail"; + label = "Livebox1:red:wifi"; gpios = <&gpio0 4 0>; }; }; @@ -68,5 +68,5 @@ reg = <0x1e400000 0x800000>; status = "ok"; - linux,part-probe = "redboot"; + linux,part-probe = "RedBoot"; };
Fix the DTS file for the Livebox 1 routers: - leds are totally wrong, fix them. - no failsafe button, use button 1 for this purpose - part probe wrong, it should be RedBoot (uppercase matters) Signed-off-by: Daniel Gonzalez Cabanelas <dgcbueu@gmail.com>