[LEDE-DEV] samba: remove browse/write able entries

Message ID	20170521065737.7500-1-rosenp@gmail.com
State	Superseded
Headers	show Return-Path: <lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> From: Rosen Penev <rosenp@gmail.com> To: lede-dev@lists.infradead.org Date: Sat, 20 May 2017 23:57:37 -0700 Message-Id: <20170521065737.7500-1-rosenp@gmail.com> summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400e:c00:0:0:0:244 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rosenp[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Subject: [LEDE-DEV] [PATCH] samba: remove browse/write able entries Precedence: list Cc: Rosen Penev <rosenp@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Lede-dev" <lede-dev-bounces@lists.infradead.org> Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org

Message ID

20170521065737.7500-1-rosenp@gmail.com

State

Superseded

Headers

From: Rosen Penev <rosenp@gmail.com>
To: lede-dev@lists.infradead.org
Date: Sat, 20 May 2017 23:57:37 -0700
Message-Id: <20170521065737.7500-1-rosenp@gmail.com>
Subject: [LEDE-DEV] [PATCH] samba: remove browse/write able entries
Precedence: list
Cc: Rosen Penev <rosenp@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "Lede-dev" <lede-dev-bounces@lists.infradead.org>
Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org

Commit Message

Rosen Penev May 21, 2017, 6:57 a.m. UTC

current LuCI defaults set the former for each individual share.
Patch is pending for the latter.

Signed-off by: Rosen Penev <rosenp@gmail.com>
---
 package/network/services/samba36/files/smb.conf.template | 2 --
 1 file changed, 2 deletions(-)

diff --git a/package/network/services/samba36/files/smb.conf.template b/package/network/services/samba36/files/smb.conf.template
index 47271d9..5f99025 100644
--- a/package/network/services/samba36/files/smb.conf.template
+++ b/package/network/services/samba36/files/smb.conf.template
@@ -6,7 +6,6 @@ 
 	unix charset = |CHARSET|
 	workgroup = |WORKGROUP|
 	local master = no
-	browseable = yes
 	deadtime = 30
 	enable core files = no
 	invalid users = root
@@ -20,5 +19,4 @@ 
 	smb passwd file = /etc/samba/smbpasswd
 	syslog = 2
 	use sendfile = yes
-	writeable = yes
 	bind interfaces only = yes