diff mbox

[LEDE-DEV] samba: Remove a few redundant options from the default config.

Message ID 20170521063550.6365-1-rosenp@gmail.com
State Accepted
Headers show

Commit Message

Rosen Penev May 21, 2017, 6:35 a.m. UTC 
The master settings seem to be compatibility settings for Windows
98 and below. guest ok conflicts with the current UCI setup where
it gets applied to directories as well. Unfortunately, the global
setting takes precedence and nullifies the local ones. encrypt
passwords defaults to yes. No reason to disable or keep it around.

Signed-off by: Rosen Penev <rosenp@gmail.com>
---
 package/network/services/samba36/files/smb.conf.template | 4 ----
 1 file changed, 4 deletions(-)

Comments

Jo-Philipp Wich June 14, 2017, 9:35 p.m. UTC | #1 
Merged into my staging tree with
http://git.lede-project.org/?p=lede/jow/staging.git;a=commitdiff;h=744380bb74.

Thank you!
diff mbox

Patch

diff --git a/package/network/services/samba36/files/smb.conf.template b/package/network/services/samba36/files/smb.conf.template
index 35e486f..47271d9 100644
--- a/package/network/services/samba36/files/smb.conf.template
+++ b/package/network/services/samba36/files/smb.conf.template
@@ -8,10 +8,7 @@ 
 	local master = no
 	browseable = yes
 	deadtime = 30
-	domain master = yes
-	encrypt passwords = yes
 	enable core files = no
-	guest ok = yes
 	invalid users = root
 	load printers = no
 	map to guest = Bad User
@@ -19,7 +16,6 @@ 
 	min receivefile size = 16384
 	null passwords = yes
 	passdb backend = smbpasswd
-	preferred master = yes
 	security = user
 	smb passwd file = /etc/samba/smbpasswd
 	syslog = 2