diff mbox

[LEDE-DEV,03/11] build: image.mk: add IMAGE_PREFIX as one of DEFAULT_DEVICE_VARS

Message ID 1483203997-12577-4-git-send-email-yszhou4tech@gmail.com
State Rejected
Headers show

Commit Message

Yousong Zhou Dec. 31, 2016, 5:06 p.m. UTC
Its value is device-specific

Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
---
 include/image.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Felix Fietkau Dec. 31, 2016, 5:16 p.m. UTC | #1
On 2016-12-31 18:06, Yousong Zhou wrote:
> Its value is device-specific
> 
> Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
> ---
>  include/image.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/image.mk b/include/image.mk
> index 93c3bbd..b83d589 100644
> --- a/include/image.mk
> +++ b/include/image.mk
> @@ -360,7 +360,7 @@ DEFAULT_DEVICE_VARS := \
>    UBOOTENV_IN_UBI KERNEL_IN_UBI \
>    BLOCKSIZE PAGESIZE SUBPAGESIZE VID_HDR_OFFSET \
>    UBINIZE_OPTS UIMAGE_NAME UBINIZE_PARTS \
> -  SUPPORTED_DEVICES IMAGE_METADATA
> +  SUPPORTED_DEVICES IMAGE_METADATA IMAGE_PREFIX
I think you should not use IMAGE_PREFIX from build command templates
directly. If you need temporary files, just use $@.<something>.

- Felix
diff mbox

Patch

diff --git a/include/image.mk b/include/image.mk
index 93c3bbd..b83d589 100644
--- a/include/image.mk
+++ b/include/image.mk
@@ -360,7 +360,7 @@  DEFAULT_DEVICE_VARS := \
   UBOOTENV_IN_UBI KERNEL_IN_UBI \
   BLOCKSIZE PAGESIZE SUBPAGESIZE VID_HDR_OFFSET \
   UBINIZE_OPTS UIMAGE_NAME UBINIZE_PARTS \
-  SUPPORTED_DEVICES IMAGE_METADATA
+  SUPPORTED_DEVICES IMAGE_METADATA IMAGE_PREFIX
 
 define Device/ExportVar
   $(1) : $(2):=$$($(2))