From patchwork Thu May 11 07:44:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 760963 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wNlVN3BHMz9sDC for ; Thu, 11 May 2017 17:44:12 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="LbIXk8Vt"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754785AbdEKHoL (ORCPT ); Thu, 11 May 2017 03:44:11 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33942 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753303AbdEKHoK (ORCPT ); Thu, 11 May 2017 03:44:10 -0400 Received: by mail-wm0-f66.google.com with SMTP id d127so4941854wmf.1; Thu, 11 May 2017 00:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4qPcSOSgDG5lUrXgSgNcdmR9jACgmbYVeHCjwdyXx3U=; b=LbIXk8Vtu1jnffMJuulVvQMoDsvGGMEGrwOf7gWHNtZh5mbDQEOn/tbDgPo4uwJPbv 0y3w9I7653/PZlLf4apRC2a+ttRyZC7IOxrVG9s4G80cZOMDLNpw9MgMpNDPKy3Yn8g9 4VymXvJPybT64XpmpEjR/GGCY5x9ABIJJd1/E7T+2n6a9wnS746AXP2fWJg/lFRDWrDS 0OYgzN2it+kLoJSk5UU1PPCHgvAXlq+wJzK+nD6a7zh/M8Bk66IixFSSRUqqSinYytsk 5rcNAc91OW/y7yp8+2H4AAflk84jVv2Y9vKAbQa4R/LY4r8nqTEsyf4dP97wKUoZpse5 ux0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4qPcSOSgDG5lUrXgSgNcdmR9jACgmbYVeHCjwdyXx3U=; b=tVCEOCS6H4Jeg3BgOrknIc4nOLTG8kklodlVNXxXdXOh6eKDNrMnINARHYKzQek1dA 4OXukPQmlJJIti7rWim31qbN8aTnE9SMlUe8obcSfRVn/chpCaLRdexqVKj44+myngHb xHS3qGh6gNNWahmXBDu5pJGhCJbJLPPNgso7srWu5YoAuopGlIP4RumlQoaF1XYIIgI3 6nlkARt4Bwlkfd2pTkoFkrapBl5F3RpwWriNisEodDgdvQP39xK1KkQMRfhQo04YPA8m 0976BMTMu9WEGKWH8AyKbn3gBalQYLQUmmZ1nWGcFI8bs8OhWVvWIzosc4QduFYRAaEI +7sQ== X-Gm-Message-State: AODbwcDb6Lhy8lf8v8AH7KxHM6rjctwV9QyvallZLbxFtfUNNRfpShf6 +oknbfxgGwVqNU2oxL8= X-Received: by 10.28.32.19 with SMTP id g19mr6230792wmg.123.1494488648410; Thu, 11 May 2017 00:44:08 -0700 (PDT) Received: from [192.168.10.165] (94-39-157-43.adsl-ull.clienti.tiscali.it. [94.39.157.43]) by smtp.googlemail.com with ESMTPSA id g25sm2008680wra.1.2017.05.11.00.44.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 May 2017 00:44:07 -0700 (PDT) Subject: Re: [PATCH] KVM: Eliminate unused variable warning on uniprocessor configs To: Paul Mackerras , kvm@vger.kernel.org Cc: kvm-ppc@vger.kernel.org, "linux-kernel@vger.kernel.org" References: <20170511034013.GB14071@fergus.ozlabs.ibm.com> From: Paolo Bonzini Message-ID: Date: Thu, 11 May 2017 09:44:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <20170511034013.GB14071@fergus.ozlabs.ibm.com> Content-Language: en-US Sender: kvm-ppc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm-ppc@vger.kernel.org On 11/05/2017 05:40, Paul Mackerras wrote: > When the > kernel is compiled with CONFIG_SMP=n, smp_call_function_many() turns > into a macro which doesn't use the 'wait' argument, leading to a > warning about the variable 'wait' being unused: > > /home/paulus/kernel/kvm/arch/powerpc/kvm/../../../virt/kvm/kvm_main.c: In function ‘kvm_make_all_cpus_request’: > /home/paulus/kernel/kvm/arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:195:7: error: unused variable ‘wait’ [-Werror=unused-variable] > bool wait = req & KVM_REQUEST_WAIT; Maybe the macro should not be a macro: Paolo --- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/linux/smp.h b/include/linux/smp.h index 8e0cb7a0f836..899c72f0933f 100644 --- a/include/linux/smp.h +++ b/include/linux/smp.h @@ -128,17 +128,18 @@ static inline void smp_send_stop(void) { } * These macros fold the SMP functionality into a single CPU system */ #define raw_smp_processor_id() 0 -static inline int up_smp_call_function(smp_call_func_t func, void *info) +static inline void smp_call_function_many(const struct cpumask *mask, + smp_call_func_t func, void *info, + bool wait); { - return 0; +} + +static inline void smp_call_function(smp_call_func_t func, void *info, bool wait); +{ } -#define smp_call_function(func, info, wait) \ - (up_smp_call_function(func, info)) static inline void smp_send_reschedule(int cpu) { } #define smp_prepare_boot_cpu() do {} while (0) -#define smp_call_function_many(mask, func, info, wait) \ - (up_smp_call_function(func, info)) static inline void call_function_init(void) { } static inline int