@@ -48,66 +48,39 @@ struct kvm_nested_guest {
};
/*
+ * We use nested rmap entries to store information so that we can find pte
+ * entries in the shadow page table of a nested guest when the host is modifying
+ * a pte for a l1 guest page. For a radix nested guest this is the nested
+ * gpa which can then be used to walk the radix shadow page table to find a
+ * pte. For a hash nested guest this is an index into the shadow hpt which can
+ * be used to find a pte. Irrespective the lpid of the nested guest is stored.
+ *
+ * These entries are stored in a rmap_nested struct. There may be multiple
+ * entries for a single l1 guest page since that guest may have multiple nested
+ * guests and map the same page into more than 1, or a single nested guest may
+ * map the same l1 guest page with multiple hpt entries. To accommodate this
+ * the rmap_nested entries are linked together in a singly linked list with the
+ * corresponding rmap entry in the rmap array of the memslot containing the
+ * head pointer of the linked list (or NULL if list is empty).
+ */
+
+/*
* We define a nested rmap entry as a single 64-bit quantity
* 0xFFF0000000000000 12-bit lpid field
* 0x000FFFFFFFFFFFC0 46-bit guest page frame number (radix) or hpt index
- * 0x0000000000000001 1-bit single entry flag
+ * 0x000000000000003F 6-bit unused field
*/
#define RMAP_NESTED_LPID_MASK 0xFFF0000000000000UL
#define RMAP_NESTED_LPID_SHIFT (52)
#define RMAP_NESTED_GPA_MASK 0x000FFFFFFFFFFFC0UL
#define RMAP_NESTED_GPA_SHIFT (6)
-#define RMAP_NESTED_IS_SINGLE_ENTRY 0x0000000000000001UL
/* Structure for a nested guest rmap entry */
struct rmap_nested {
struct llist_node list;
- u64 rmap;
+ u64 rmap; /* layout defined above */
};
-/*
- * for_each_nest_rmap_safe - iterate over the list of nested rmap entries
- * safe against removal of the list entry or NULL list
- * @pos: a (struct rmap_nested *) to use as a loop cursor
- * @node: pointer to the first entry
- * NOTE: this can be NULL
- * @rmapp: an (unsigned long *) in which to return the rmap entries on each
- * iteration
- * NOTE: this must point to already allocated memory
- *
- * The nested_rmap is a llist of (struct rmap_nested) entries pointed to by the
- * rmap entry in the memslot. The list is always terminated by a "single entry"
- * stored in the list element of the final entry of the llist. If there is ONLY
- * a single entry then this is itself in the rmap entry of the memslot, not a
- * llist head pointer.
- *
- * Note that the iterator below assumes that a nested rmap entry is always
- * non-zero. This is true for our usage because the LPID field is always
- * non-zero (zero is reserved for the host).
- *
- * This should be used to iterate over the list of rmap_nested entries with
- * processing done on the u64 rmap value given by each iteration. This is safe
- * against removal of list entries and it is always safe to call free on (pos).
- *
- * e.g.
- * struct rmap_nested *cursor;
- * struct llist_node *first;
- * unsigned long rmap;
- * for_each_nest_rmap_safe(cursor, first, &rmap) {
- * do_something(rmap);
- * free(cursor);
- * }
- */
-#define for_each_nest_rmap_safe(pos, node, rmapp) \
- for ((pos) = llist_entry((node), typeof(*(pos)), list); \
- (node) && \
- (*(rmapp) = ((RMAP_NESTED_IS_SINGLE_ENTRY & ((u64) (node))) ? \
- ((u64) (node)) : ((pos)->rmap))) && \
- (((node) = ((RMAP_NESTED_IS_SINGLE_ENTRY & ((u64) (node))) ? \
- ((struct llist_node *) ((pos) = NULL)) : \
- (pos)->list.next)), true); \
- (pos) = llist_entry((node), typeof(*(pos)), list))
-
struct kvm_nested_guest *kvmhv_get_nested(struct kvm *kvm, int l1_lpid,
bool create);
void kvmhv_put_nested(struct kvm_nested_guest *gp);
@@ -800,31 +800,20 @@ static inline bool kvmhv_n_rmap_is_equal(u64 rmap_1, u64 rmap_2, u64 mask)
/* called with kvm->mmu_lock held */
void kvmhv_insert_nest_rmap(unsigned long *rmapp, struct rmap_nested **n_rmap)
{
- struct llist_node *entry = ((struct llist_head *) rmapp)->first;
+ struct llist_head *head = (struct llist_head *) rmapp;
struct rmap_nested *cursor;
- u64 rmap, new_rmap = (*n_rmap)->rmap;
+ u64 new_rmap = (*n_rmap)->rmap;
- /* Are there any existing entries? */
- if (!(*rmapp)) {
- /* No -> use the rmap as a single entry */
- *rmapp = new_rmap | RMAP_NESTED_IS_SINGLE_ENTRY;
- return;
- }
-
- /* Do any entries match what we're trying to insert? */
- for_each_nest_rmap_safe(cursor, entry, &rmap) {
- if (kvmhv_n_rmap_is_equal(rmap, new_rmap, RMAP_NESTED_LPID_MASK
- | RMAP_NESTED_GPA_MASK))
+ /* Do any existing entries match what we're trying to insert? */
+ llist_for_each_entry(cursor, head->first, list) {
+ if (kvmhv_n_rmap_is_equal(cursor->rmap, new_rmap,
+ RMAP_NESTED_LPID_MASK |
+ RMAP_NESTED_GPA_MASK))
return;
}
- /* Do we need to create a list or just add the new entry? */
- rmap = *rmapp;
- if (rmap & RMAP_NESTED_IS_SINGLE_ENTRY) /* Not previously a list */
- *rmapp = 0UL;
- llist_add(&((*n_rmap)->list), (struct llist_head *) rmapp);
- if (rmap & RMAP_NESTED_IS_SINGLE_ENTRY) /* Not previously a list */
- (*n_rmap)->list.next = (struct llist_node *) rmap;
+ /* Insert the new entry */
+ llist_add(&((*n_rmap)->list), head);
/* Set NULL so not freed by caller */
*n_rmap = NULL;
@@ -874,9 +863,9 @@ void kvmhv_update_nest_rmap_rc_list(struct kvm *kvm, unsigned long *rmapp,
unsigned long clr, unsigned long set,
unsigned long hpa, unsigned long nbytes)
{
- struct llist_node *entry = ((struct llist_head *) rmapp)->first;
+ struct llist_head *head = (struct llist_head *) rmapp;
struct rmap_nested *cursor;
- unsigned long rmap, mask;
+ unsigned long mask;
if ((clr | set) & ~(_PAGE_DIRTY | _PAGE_ACCESSED))
return;
@@ -884,8 +873,9 @@ void kvmhv_update_nest_rmap_rc_list(struct kvm *kvm, unsigned long *rmapp,
mask = PTE_RPN_MASK & ~(nbytes - 1);
hpa &= mask;
- for_each_nest_rmap_safe(cursor, entry, &rmap)
- kvmhv_update_nest_rmap_rc(kvm, rmap, clr, set, hpa, mask);
+ llist_for_each_entry(cursor, head->first, list)
+ kvmhv_update_nest_rmap_rc(kvm, cursor->rmap, clr, set, hpa,
+ mask);
}
/*
@@ -924,11 +914,10 @@ static void kvmhv_invalidate_nest_rmap_list(struct kvm *kvm,
unsigned long mask)
{
struct llist_node *entry = llist_del_all((struct llist_head *) rmapp);
- struct rmap_nested *cursor;
- unsigned long rmap;
+ struct rmap_nested *cursor, *next;
- for_each_nest_rmap_safe(cursor, entry, &rmap) {
- kvmhv_invalidate_nest_rmap(kvm, rmap, hpa, mask);
+ llist_for_each_entry_safe(cursor, next, entry, list) {
+ kvmhv_invalidate_nest_rmap(kvm, cursor->rmap, hpa, mask);
kfree(cursor);
}
}
@@ -966,12 +955,12 @@ static void kvmhv_free_memslot_nest_rmap(struct kvm_memory_slot *free)
unsigned long page;
for (page = 0; page < free->npages; page++) {
- unsigned long rmap, *rmapp = &free->arch.rmap[page];
- struct rmap_nested *cursor;
+ unsigned long *rmapp = &free->arch.rmap[page];
+ struct rmap_nested *cursor, *next;
struct llist_node *entry;
entry = llist_del_all((struct llist_head *) rmapp);
- for_each_nest_rmap_safe(cursor, entry, &rmap)
+ llist_for_each_entry_safe(cursor, next, entry, list)
kfree(cursor);
}
}
The nested rmap entries are used to track nested pages which map a given guest page such that that information can be retrieved from the guest memslot. These entries are stored in the guest memslot as a singly linked list (llist) with the next pointer of the last entry in the list used to store a "single entry" to save having to add another list entry. This approach while saving a small amount of memory significantly complicates the list handling. For simplicity and code clarity remove the existence of these "single entries" and always insert another list entry to hold the final value. No functional change. Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com> --- arch/powerpc/include/asm/kvm_book3s_64.h | 65 ++++++++++---------------------- arch/powerpc/kvm/book3s_hv_nested.c | 51 ++++++++++--------------- 2 files changed, 39 insertions(+), 77 deletions(-)