From patchwork Thu Apr 5 17:56:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 895485 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=kvm-ppc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="l8Ft0NwY"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40H9WM5gZbz9s2g for ; Fri, 6 Apr 2018 03:56:47 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751412AbeDER4r (ORCPT ); Thu, 5 Apr 2018 13:56:47 -0400 Received: from mail-pl0-f68.google.com ([209.85.160.68]:44330 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751352AbeDER4q (ORCPT ); Thu, 5 Apr 2018 13:56:46 -0400 Received: by mail-pl0-f68.google.com with SMTP id b6-v6so18240651pla.11 for ; Thu, 05 Apr 2018 10:56:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+uGKwguvcOo4xKBmSRSlp3ZVzJ/Yp9/B/i/+wgfPEls=; b=l8Ft0NwYMzK6XFTi04T/3aL1uJa/fLVWk5poWEiIVuRuw6E2KjRJm2TNqGbFDliXwm 544X9jhe9f5OtOPuwMFmbtgN7CvAqB2onmyguDUb5ZH5XBcTvstR2ylV04+NlaBPgRVT 3Kg+G/M98IC5ubi7CRsL4EGL6W5pIALlYf1IgqGUqXK6jzMBL7+NQgOWI13uiDMVGrNN rx+VALB3mz3BRAti0pUa8iM0c0vg8EDhitzDPMKjLyq0Zt/pW+PxxY+y0gMZHvduUZkm UV/5dlKu7XcY6xtYmmygL4lHHRUr0XSWg3NydYz6K2UpcPQWv7p+xpTK22FYah+It7lb dyZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+uGKwguvcOo4xKBmSRSlp3ZVzJ/Yp9/B/i/+wgfPEls=; b=ZsfM+CzSqU2PqTPw6JNCsvqmpd9xG3ZCxZK2xJLtp+pdqok5LcKyiVpauqR1E6B0uA IXwd0Su1JsLIgm6RmJ6LqTIZ5sLImHUFpj0cmqabcU2AwnfvjOI2YTsT39bqQMZn2uZ8 Zx0+rIrdY/Ny00N9uIRvEEXfTbtDMUHfKA4fj41s81fPpT0SMyLcEACIsdZDTTvh/5K8 ynDZiPhlRcD1kBiQ9iLt6TZmiOg1REodXDbFaQkTS71+rSb/wQwQsn0A/G5ytMjrUuTg V692fTOrREx+ZeX1FUvBQpLkTfJqkVMlW3LjTVoi+58MDJIGpLEC5NZ+FgtRjlwdeeXv kFvg== X-Gm-Message-State: AElRT7ETCMAbxIKWtBslUUXsysqpsBk6zK/tvjYqYS+k9uUR+VTQelOx cMYDrIdRGFvU+p+Wbizy2VCRtg== X-Google-Smtp-Source: AIpwx4+1DQejx8FALaMslCuoS2nNibkYjRjGa9kLa7/MfY1AzQMmVhG/ZlwiW3SJMXmoNdlKCPoPSA== X-Received: by 10.99.103.71 with SMTP id b68mr10854927pgc.60.1522951005947; Thu, 05 Apr 2018 10:56:45 -0700 (PDT) Received: from roar.au.ibm.com (59-102-70-78.tpgi.com.au. [59.102.70.78]) by smtp.gmail.com with ESMTPSA id g11sm14917562pfi.15.2018.04.05.10.56.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Apr 2018 10:56:45 -0700 (PDT) From: Nicholas Piggin To: kvm-ppc@vger.kernel.org Cc: Nicholas Piggin , linuxppc-dev@lists.ozlabs.org, Paul Mackerras , Balbir Singh Subject: [PATCH 1/2] KVM: PPC: Book3S HV: trace_tlbie must not be called in realmode Date: Fri, 6 Apr 2018 03:56:30 +1000 Message-Id: <20180405175631.31381-2-npiggin@gmail.com> X-Mailer: git-send-email 2.16.3 In-Reply-To: <20180405175631.31381-1-npiggin@gmail.com> References: <20180405175631.31381-1-npiggin@gmail.com> Sender: kvm-ppc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm-ppc@vger.kernel.org This crashes with a "Bad real address for load" attempting to load from the vmalloc region in realmode (faulting address is in DAR). Oops: Bad interrupt in KVM entry/exit code, sig: 6 [#1] LE SMP NR_CPUS=2048 NUMA PowerNV CPU: 53 PID: 6582 Comm: qemu-system-ppc Not tainted 4.16.0-01530-g43d1859f0994 NIP: c0000000000155ac LR: c0000000000c2430 CTR: c000000000015580 REGS: c000000fff76dd80 TRAP: 0200 Not tainted (4.16.0-01530-g43d1859f0994) MSR: 9000000000201003 CR: 48082222 XER: 00000000 CFAR: 0000000102900ef0 DAR: d00017fffd941a28 DSISR: 00000040 SOFTE: 3 NIP [c0000000000155ac] perf_trace_tlbie+0x2c/0x1a0 LR [c0000000000c2430] do_tlbies+0x230/0x2f0 I suspect the reason is the per-cpu data is not in the linear chunk. This could be restored if that was able to be fixed, but for now, just remove the tracepoints. Fixes: 0428491cba ("powerpc/mm: Trace tlbie(l) instructions") Signed-off-by: Nicholas Piggin --- arch/powerpc/kvm/book3s_hv_rm_mmu.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/arch/powerpc/kvm/book3s_hv_rm_mmu.c b/arch/powerpc/kvm/book3s_hv_rm_mmu.c index e1c083fbe434..78e6a392330f 100644 --- a/arch/powerpc/kvm/book3s_hv_rm_mmu.c +++ b/arch/powerpc/kvm/book3s_hv_rm_mmu.c @@ -470,8 +470,6 @@ static void do_tlbies(struct kvm *kvm, unsigned long *rbvalues, for (i = 0; i < npages; ++i) { asm volatile(PPC_TLBIE_5(%0,%1,0,0,0) : : "r" (rbvalues[i]), "r" (kvm->arch.lpid)); - trace_tlbie(kvm->arch.lpid, 0, rbvalues[i], - kvm->arch.lpid, 0, 0, 0); } if (cpu_has_feature(CPU_FTR_P9_TLBIE_BUG)) { @@ -492,8 +490,6 @@ static void do_tlbies(struct kvm *kvm, unsigned long *rbvalues, for (i = 0; i < npages; ++i) { asm volatile(PPC_TLBIEL(%0,%1,0,0,0) : : "r" (rbvalues[i]), "r" (0)); - trace_tlbie(kvm->arch.lpid, 1, rbvalues[i], - 0, 0, 0, 0); } asm volatile("ptesync" : : : "memory"); }