| Message ID | 20170620043035.avphtcoght2iiyug@oak.ozlabs.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
2017-06-20 14:30+1000, Paul Mackerras: > Paolo, > > Please do a pull from my kvm-ppc-fixes branch to get 6 commits that I > would like to have go into 4.12, because they fix problems that could > cause hangs or crashes in the host (the first and last commit, but > only on POWER9 systems), or they fix problems that could allow guests > to potentially affect or disrupt the execution of the controlling > userspace (the other four). They are all marked to go to stable. Pulled, but only locally at the moment -- would you like me to apply "[PATCH v2] KVM: MIPS: Fix maybe-uninitialized build failure" directly? -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 20/06/2017 14:39, Radim Krčmář wrote: > 2017-06-20 14:30+1000, Paul Mackerras: >> Paolo, >> >> Please do a pull from my kvm-ppc-fixes branch to get 6 commits that I >> would like to have go into 4.12, because they fix problems that could >> cause hangs or crashes in the host (the first and last commit, but >> only on POWER9 systems), or they fix problems that could allow guests >> to potentially affect or disrupt the execution of the controlling >> userspace (the other four). They are all marked to go to stable. > > Pulled, but only locally at the moment -- would you like me to apply > "[PATCH v2] KVM: MIPS: Fix maybe-uninitialized build failure" directly? Why not, isn't the tree yours? :) Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2017-06-20 14:55+0200, Paolo Bonzini: > On 20/06/2017 14:39, Radim Krčmář wrote: > > 2017-06-20 14:30+1000, Paul Mackerras: > >> Paolo, > >> > >> Please do a pull from my kvm-ppc-fixes branch to get 6 commits that I > >> would like to have go into 4.12, because they fix problems that could > >> cause hangs or crashes in the host (the first and last commit, but > >> only on POWER9 systems), or they fix problems that could allow guests > >> to potentially affect or disrupt the execution of the controlling > >> userspace (the other four). They are all marked to go to stable. > > > > Pulled, but only locally at the moment -- would you like me to apply > > "[PATCH v2] KVM: MIPS: Fix maybe-uninitialized build failure" directly? > > Why not, isn't the tree yours? :) Right, and the arch doesn't even match ... let's forget I asked. :) Pushed into kvm/master, thanks. -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jun 20, 2017 at 05:17:01PM +0200, Radim Krčmář wrote: > 2017-06-20 14:55+0200, Paolo Bonzini: > > On 20/06/2017 14:39, Radim Krčmář wrote: > > > 2017-06-20 14:30+1000, Paul Mackerras: > > >> Paolo, > > >> > > >> Please do a pull from my kvm-ppc-fixes branch to get 6 commits that I > > >> would like to have go into 4.12, because they fix problems that could > > >> cause hangs or crashes in the host (the first and last commit, but > > >> only on POWER9 systems), or they fix problems that could allow guests > > >> to potentially affect or disrupt the execution of the controlling > > >> userspace (the other four). They are all marked to go to stable. > > > > > > Pulled, but only locally at the moment -- would you like me to apply > > > "[PATCH v2] KVM: MIPS: Fix maybe-uninitialized build failure" directly? > > > > Why not, isn't the tree yours? :) > > Right, and the arch doesn't even match ... let's forget I asked. :) > > Pushed into kvm/master, thanks. Thanks. On a related note, we still have the warning in virt/kvm/kvm_main.c for CONFIG_SMP=n builds about the variable 'wait' being unused in kvm_make_all_cpus_request(), because smp_call_function_many() doesn't reference its 'wait' argument for uniprocessor configs. This then causes the build to fail on powerpc because kvm_main.c actually gets compiled under arch/powerpc, and we use -Werror for arch/powerpc by default. Paolo posted a sketch of a patch to make smp_call_function_many be a static inline instead of a macro on UP, but it wasn't quite right and no-one sent it anywhere. Paolo, if you're OK with me cleaning it up and sending it on, I'll do that. Paul. -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 21/06/2017 01:37, Paul Mackerras wrote: >> Right, and the arch doesn't even match ... let's forget I asked. :) >> >> Pushed into kvm/master, thanks. > Thanks. > > On a related note, we still have the warning in virt/kvm/kvm_main.c > for CONFIG_SMP=n builds about the variable 'wait' being unused in > kvm_make_all_cpus_request(), because smp_call_function_many() doesn't > reference its 'wait' argument for uniprocessor configs. > > This then causes the build to fail on powerpc because kvm_main.c > actually gets compiled under arch/powerpc, and we use -Werror for > arch/powerpc by default. > > Paolo posted a sketch of a patch to make smp_call_function_many be a > static inline instead of a macro on UP, but it wasn't quite right and > no-one sent it anywhere. Paolo, if you're OK with me cleaning it up > and sending it on, I'll do that. The problem is that it breaks MIPS, which uses an unused variable. I'll send an alternative patch that is confined in KVM. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Paolo, Please do a pull from my kvm-ppc-fixes branch to get 6 commits that I would like to have go into 4.12, because they fix problems that could cause hangs or crashes in the host (the first and last commit, but only on POWER9 systems), or they fix problems that could allow guests to potentially affect or disrupt the execution of the controlling userspace (the other four). They are all marked to go to stable. Thanks, Paul. The following changes since commit 08332893e37af6ae779367e78e444f8f9571511d: Linux 4.12-rc2 (2017-05-21 19:30:23 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc kvm-ppc-fixes for you to fetch changes up to 3d3efb68c19e539f0535c93a5258c1299270215f: KVM: PPC: Book3S HV: Ignore timebase offset on POWER9 DD1 (2017-06-16 16:04:57 +1000) ---------------------------------------------------------------- Paul Mackerras (6): KVM: PPC: Book3S HV: Cope with host using large decrementer mode KVM: PPC: Book3S HV: Context-switch EBB registers properly KVM: PPC: Book3S HV: Restore critical SPRs to host values on guest exit KVM: PPC: Book3S HV: Preserve userspace HTM state properly KVM: PPC: Book3S HV: Save/restore host values of debug registers KVM: PPC: Book3S HV: Ignore timebase offset on POWER9 DD1 arch/powerpc/kvm/book3s_hv.c | 51 ++++++++++++++++++++++ arch/powerpc/kvm/book3s_hv_interrupts.S | 12 +++++- arch/powerpc/kvm/book3s_hv_rmhandlers.S | 75 ++++++++++++++++++++++++--------- 3 files changed, 118 insertions(+), 20 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html