| Message ID | 1447922251-54261-2-git-send-email-borntraeger@de.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
On 19/11/15 09:37, Christian Borntraeger wrote: > From: David Hildenbrand <dahi@linux.vnet.ibm.com> > > Let's provide a function to lookup a VCPU by id. > > Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com> > Reviewed-by: Dominik Dingel <dingel@linux.vnet.ibm.com> > Signed-off-by: David Hildenbrand <dahi@linux.vnet.ibm.com> > Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com> > [split patch from refactoring patch] > --- > include/linux/kvm_host.h | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 5706a21..b9f345f 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -460,6 +460,17 @@ static inline struct kvm_vcpu *kvm_get_vcpu(struct kvm *kvm, int i) > (vcpup = kvm_get_vcpu(kvm, idx)) != NULL; \ > idx++) > > +static inline struct kvm_vcpu *kvm_lookup_vcpu(struct kvm *kvm, int id) > +{ > + struct kvm_vcpu *vcpu; > + int i; > + > + kvm_for_each_vcpu(i, vcpu, kvm) > + if (vcpu->vcpu_id == id) > + return vcpu; > + return NULL; > +} > + Any chance that you name this function differently? Otherwise we've got two functions that sound very similar and also have similar prototypes: - kvm_get_vcpu(struct kvm *kvm, int i) - kvm_lookup_vcpu(struct kvm *kvm, int id) I'm pretty sure this will cause confusion in the future! ==> Could you maybe name the new function something like "kvm_lookup_vcpu_by_id" or "kvm_get_vcpu_by_id" instead? Also a short comment before the function would be nice to make the reader aware of the difference (e.g. when hot-plugging) between the vcpu-id and array-id. Otherwise: +1 for finally having a proper common function for this! Thomas -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Any chance that you name this function differently? Otherwise we've got > two functions that sound very similar and also have similar prototypes: > > - kvm_get_vcpu(struct kvm *kvm, int i) > - kvm_lookup_vcpu(struct kvm *kvm, int id) > > I'm pretty sure this will cause confusion in the future! > ==> Could you maybe name the new function something like > "kvm_lookup_vcpu_by_id" or "kvm_get_vcpu_by_id" instead? Had that in a previous version but decided to name it that way ... hmm ... other opinions? > > Also a short comment before the function would be nice to make the > reader aware of the difference (e.g. when hot-plugging) between the > vcpu-id and array-id. Also not sure as the header directly includes the (for my eyes ;) ) easy code. I would agree for a pure prototype. Other opinions? > > Otherwise: +1 for finally having a proper common function for this! > Thanks for having a look Thomas! David -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 19/11/2015 13:55, David Hildenbrand wrote: >> > >> > I'm pretty sure this will cause confusion in the future! >> > ==> Could you maybe name the new function something like >> > "kvm_lookup_vcpu_by_id" or "kvm_get_vcpu_by_id" instead? > Had that in a previous version but decided to name it that way ... hmm ... > other opinions? Having _by_id at the end of the name makes sense indeed. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/19/2015 02:13 PM, Paolo Bonzini wrote: > > > On 19/11/2015 13:55, David Hildenbrand wrote: >>>> >>>> I'm pretty sure this will cause confusion in the future! >>>> ==> Could you maybe name the new function something like >>>> "kvm_lookup_vcpu_by_id" or "kvm_get_vcpu_by_id" instead? >> Had that in a previous version but decided to name it that way ... hmm ... >> other opinions? > > Having _by_id at the end of the name makes sense indeed. David, I will fix up the function name myself to kvm_get_vcpu_by_id. Ok? -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> On 11/19/2015 02:13 PM, Paolo Bonzini wrote: > > > > > > On 19/11/2015 13:55, David Hildenbrand wrote: > >>>> > >>>> I'm pretty sure this will cause confusion in the future! > >>>> ==> Could you maybe name the new function something like > >>>> "kvm_lookup_vcpu_by_id" or "kvm_get_vcpu_by_id" instead? > >> Had that in a previous version but decided to name it that way ... hmm ... > >> other opinions? > > > > Having _by_id at the end of the name makes sense indeed. > > David, > I will fix up the function name myself to kvm_get_vcpu_by_id. Ok? Sure, thanks a lot! David -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index 5706a21..b9f345f 100644 --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -460,6 +460,17 @@ static inline struct kvm_vcpu *kvm_get_vcpu(struct kvm *kvm, int i) (vcpup = kvm_get_vcpu(kvm, idx)) != NULL; \ idx++) +static inline struct kvm_vcpu *kvm_lookup_vcpu(struct kvm *kvm, int id) +{ + struct kvm_vcpu *vcpu; + int i; + + kvm_for_each_vcpu(i, vcpu, kvm) + if (vcpu->vcpu_id == id) + return vcpu; + return NULL; +} + #define kvm_for_each_memslot(memslot, slots) \ for (memslot = &slots->memslots[0]; \ memslot < slots->memslots + KVM_MEM_SLOTS_NUM && memslot->npages;\