From patchwork Thu Sep 24 14:00:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 522354 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9A8AA14029E for ; Fri, 25 Sep 2015 00:06:47 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756639AbbIXOBn (ORCPT ); Thu, 24 Sep 2015 10:01:43 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:61518 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756254AbbIXOBZ (ORCPT ); Thu, 24 Sep 2015 10:01:25 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NV6007PAPMBQQ70@mailout4.w1.samsung.com>; Thu, 24 Sep 2015 15:01:23 +0100 (BST) X-AuditID: cbfec7f5-f794b6d000001495-f9-560402335132 Received: from eusync4.samsung.com ( [203.254.199.214]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id F2.E8.05269.33204065; Thu, 24 Sep 2015 15:01:23 +0100 (BST) Received: from AMDC1061.digital.local ([106.116.147.88]) by eusync4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NV600IK6PLM8670@eusync4.samsung.com>; Thu, 24 Sep 2015 15:01:23 +0100 (BST) From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Alexander Graf , Gleb Natapov , Paolo Bonzini , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 15/19] KVM: PPC: e500: fix handling local_sid_lookup result Date: Thu, 24 Sep 2015 16:00:23 +0200 Message-id: <1443103227-25612-16-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> References: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMLMWRmVeSWpSXmKPExsVy+t/xa7rGTCxhBktWsVvcWneO1eLHw05G i40z1rNafGhqZbb48vM6o8WbT9oWc6YWWlzeNYfN4vf3f6wWa4/cZbfY0nCIzWLNkcXsFvu3 /WN14PVY9LKBxaPnTQurx6ZVnWwe52csZPR4v+8qm8fcXX2MHn1bVjF6rN9ylcXj8ya5AM4o LpuU1JzMstQifbsErozDW7eyFbRyVPy/7NPAeJCti5GDQ0LARGLKX+EuRk4gU0ziwr31QGEu DiGBpYwSj2YcZIVwmpgk5iyYwg5SxSagKfF38002EFtEQEFic+8zsCJmgWPMEkvfvGQFSQgL eEu0PnjDBGKzCKhK7Lj/GayBV8BFYs3kJjaIdXISJ49NBqvnBIq/nboJrF5IwFnixJFZbBMY eRcwMqxiFE0tTS4oTkrPNdIrTswtLs1L10vOz93ECAnarzsYlx6zOsQowMGoxMM7U4c5TIg1 say4MvcQowQHs5IIL8d7oBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHembvehwgJpCeWpGanphak FsFkmTg4pRoYLzz/9OyCZdm+XVtPvt6kOZmp5s+J9Ul1z/KDeZJ+Vj7cUNa2SpajulHgTe6j hsCaXu+/V4M6k/Un3GIK1mX/nBOefeLf0ceH7RfzrTtZ3+yhEjn/CQejefN2SbfMI8X3Jgep qgnmur3iuV9i90J2RsbP4oVHwpbsd7V325vwtC/l/PN2LUtmJZbijERDLeai4kQAe3yKk1YC AAA= Sender: kvm-ppc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm-ppc@vger.kernel.org The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda Acked-by: Scott Wood --- Hi, To avoid problems with too many mail recipients I have sent whole patchset only to LKML. Anyway patches have no dependencies. Regards Andrzej --- arch/powerpc/kvm/e500.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/kvm/e500.c b/arch/powerpc/kvm/e500.c index b29ce75..32fdab5 100644 --- a/arch/powerpc/kvm/e500.c +++ b/arch/powerpc/kvm/e500.c @@ -237,7 +237,8 @@ void kvmppc_e500_tlbil_one(struct kvmppc_vcpu_e500 *vcpu_e500, struct kvm_book3e_206_tlb_entry *gtlbe) { struct vcpu_id_table *idt = vcpu_e500->idt; - unsigned int pr, tid, ts, pid; + unsigned int pr, tid, ts; + int pid; u32 val, eaddr; unsigned long flags;