From patchwork Tue Apr 16 01:07:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Scott Wood X-Patchwork-Id: 236815 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C87532C00F2 for ; Tue, 16 Apr 2013 11:07:21 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934863Ab3DPBHU (ORCPT ); Mon, 15 Apr 2013 21:07:20 -0400 Received: from co1ehsobe002.messaging.microsoft.com ([216.32.180.185]:36928 "EHLO co1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934834Ab3DPBHT (ORCPT ); Mon, 15 Apr 2013 21:07:19 -0400 Received: from mail181-co1-R.bigfish.com (10.243.78.229) by CO1EHSOBE015.bigfish.com (10.243.66.78) with Microsoft SMTP Server id 14.1.225.23; Tue, 16 Apr 2013 01:07:18 +0000 Received: from mail181-co1 (localhost [127.0.0.1]) by mail181-co1-R.bigfish.com (Postfix) with ESMTP id 667EADC016F; Tue, 16 Apr 2013 01:07:18 +0000 (UTC) X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPV:NLI; H:mail.freescale.net; RD:none; EFVD:NLI X-SpamScore: 0 X-BigFish: VS0(zzzz1f42h1fc6h1ee6h1de0h1fdah1202h1e76h1d1ah1d2ahzz8275bhz2dh2a8h668h839hd24he5bhf0ah1288h12a5h12a9h12bdh12e5h137ah139eh13b6h1441h1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1155h) Received: from mail181-co1 (localhost.localdomain [127.0.0.1]) by mail181-co1 (MessageSwitch) id 1366074435634341_31180; Tue, 16 Apr 2013 01:07:15 +0000 (UTC) Received: from CO1EHSMHS012.bigfish.com (unknown [10.243.78.245]) by mail181-co1.bigfish.com (Postfix) with ESMTP id 8E525980067; Tue, 16 Apr 2013 01:07:15 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by CO1EHSMHS012.bigfish.com (10.243.66.22) with Microsoft SMTP Server (TLS) id 14.1.225.23; Tue, 16 Apr 2013 01:07:15 +0000 Received: from tx30smr01.am.freescale.net (10.81.153.31) by 039-SN1MMR1-002.039d.mgd.msft.net (10.84.1.15) with Microsoft SMTP Server (TLS) id 14.2.328.11; Tue, 16 Apr 2013 01:07:13 +0000 Received: from snotra.am.freescale.net ([10.214.83.122]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id r3G17Bdk002191; Mon, 15 Apr 2013 18:07:12 -0700 From: Scott Wood To: Alexander Graf CC: , , Scott Wood Subject: [PATCH] kvm/ppc: don't call complete_mmio_load when it's a store Date: Mon, 15 Apr 2013 20:07:11 -0500 Message-ID: <1366074431-13992-1-git-send-email-scottwood@freescale.com> X-Mailer: git-send-email 1.7.10.4 MIME-Version: 1.0 X-OriginatorOrg: freescale.com Sender: kvm-ppc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm-ppc@vger.kernel.org complete_mmio_load writes back the mmio result into the destination register. Doing this on a store results in register corruption. Signed-off-by: Scott Wood --- arch/powerpc/kvm/powerpc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c index 16b4595..a822659 100644 --- a/arch/powerpc/kvm/powerpc.c +++ b/arch/powerpc/kvm/powerpc.c @@ -683,7 +683,6 @@ int kvmppc_handle_store(struct kvm_run *run, struct kvm_vcpu *vcpu, if (!kvm_io_bus_write(vcpu->kvm, KVM_MMIO_BUS, run->mmio.phys_addr, bytes, &run->mmio.data)) { - kvmppc_complete_mmio_load(vcpu, run); vcpu->mmio_needed = 0; return EMULATE_DONE; }