| Message ID | 1525674016-6703-1-git-send-email-wei.guo.simon@gmail.com |
|---|---|
| Headers | show |
| Series | KVM: PPC: reimplement mmio emulation with analyse_instr() | expand |
On Mon, May 07, 2018 at 02:20:06PM +0800, wei.guo.simon@gmail.com wrote: > From: Simon Guo <wei.guo.simon@gmail.com> > > We already have analyse_instr() which analyzes instructions for the instruction > type, size, addtional flags, etc. What kvmppc_emulate_loadstore() did is somehow > duplicated and it will be good to utilize analyse_instr() to reimplement the > code. The advantage is that the code logic will be shared and more clean to be > maintained. > > This patch series reimplement kvmppc_emulate_loadstore() for various load/store > instructions. > > The testcase locates at: > https://github.com/justdoitqd/publicFiles/blob/master/test_mmio.c > > - Tested at both PR/HV KVM. > - Also tested with little endian host & big endian guest. This series looks good. I have just a couple of comments on two of the patches. Thanks, Paul. -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, May 07, 2018 at 02:20:06PM +0800, wei.guo.simon@gmail.com wrote: > From: Simon Guo <wei.guo.simon@gmail.com> > > We already have analyse_instr() which analyzes instructions for the instruction > type, size, addtional flags, etc. What kvmppc_emulate_loadstore() did is somehow > duplicated and it will be good to utilize analyse_instr() to reimplement the > code. The advantage is that the code logic will be shared and more clean to be > maintained. I have put patches 1-3 into my kvm-ppc-next branch. Thanks, Paul. -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Simon Guo <wei.guo.simon@gmail.com> We already have analyse_instr() which analyzes instructions for the instruction type, size, addtional flags, etc. What kvmppc_emulate_loadstore() did is somehow duplicated and it will be good to utilize analyse_instr() to reimplement the code. The advantage is that the code logic will be shared and more clean to be maintained. This patch series reimplement kvmppc_emulate_loadstore() for various load/store instructions. The testcase locates at: https://github.com/justdoitqd/publicFiles/blob/master/test_mmio.c - Tested at both PR/HV KVM. - Also tested with little endian host & big endian guest. Tested instruction list: lbz lbzu lbzx ld ldbrx ldu ldx lfd lfdu lfdx lfiwax lfiwzx lfs lfsu lfsx lha lhau lhax lhbrx lhz lhzu lhzx lvx lwax lwbrx lwz lwzu lwzx lxsdx lxsiwax lxsiwzx lxsspx lxvd2x lxvdsx lxvw4x stb stbu stbx std stdbrx stdu stdx stfd stfdu stfdx stfiwx stfs stfsx sth sthbrx sthu sthx stvx stw stwbrx stwu stwx stxsdx stxsiwx stxsspx stxvd2x stxvw4x lvebx stvebx lvehx stvehx lvewx stvewx V2 changes: 1) correct patch split issue in v1. 2) revise some commit message/code comment per review comment 3) remove incorrect special handling for stxsiwx 4) remove mmio_update_ra related and move the RA update into kvmppc_emulate_loadstore(). 5) rework giveup_ext() which is only meaningful when not NULL. 6) rewrite VMX emulation code and cover rest VMX instructions: lvebx stvebx lvehx stvehx lvewx stvewx Simon Guo (10): KVM: PPC: add pt_regs into kvm_vcpu_arch and move vcpu->arch.gpr[] into it KVM: PPC: mov nip/ctr/lr/xer registers to pt_regs in kvm_vcpu_arch KVM: PPC: Fix a mmio_host_swabbed uninitialized usage issue when VMX store KVM: PPC: add KVMPPC_VSX_COPY_WORD_LOAD_DUMP type support for mmio emulation KVM: PPC: reimplement non-SIMD LOAD/STORE instruction mmio emulation with analyse_intr() input KVM: PPC: add giveup_ext() hook for PPC KVM ops KVM: PPC: reimplement LOAD_FP/STORE_FP instruction mmio emulation with analyse_intr() input KVM: PPC: reimplements LOAD_VSX/STORE_VSX instruction mmio emulation with analyse_intr() input KVM: PPC: expand mmio_vsx_copy_type to mmio_copy_type to cover VMX load/store elem types KVM: PPC: reimplements LOAD_VMX/STORE_VMX instruction mmio emulation with analyse_intr() input arch/powerpc/include/asm/kvm_book3s.h | 20 +- arch/powerpc/include/asm/kvm_book3s_64.h | 20 +- arch/powerpc/include/asm/kvm_booke.h | 20 +- arch/powerpc/include/asm/kvm_host.h | 17 +- arch/powerpc/include/asm/kvm_ppc.h | 17 +- arch/powerpc/kernel/asm-offsets.c | 18 +- arch/powerpc/kvm/book3s.c | 4 +- arch/powerpc/kvm/book3s_32_mmu.c | 2 +- arch/powerpc/kvm/book3s_64_vio_hv.c | 2 +- arch/powerpc/kvm/book3s_hv.c | 6 +- arch/powerpc/kvm/book3s_hv_builtin.c | 6 +- arch/powerpc/kvm/book3s_hv_rm_mmu.c | 15 +- arch/powerpc/kvm/book3s_hv_rm_xics.c | 2 +- arch/powerpc/kvm/book3s_hv_tm.c | 10 +- arch/powerpc/kvm/book3s_hv_tm_builtin.c | 10 +- arch/powerpc/kvm/book3s_pr.c | 73 +-- arch/powerpc/kvm/book3s_xive_template.c | 4 +- arch/powerpc/kvm/booke.c | 41 +- arch/powerpc/kvm/booke_emulate.c | 6 +- arch/powerpc/kvm/e500_emulate.c | 6 +- arch/powerpc/kvm/e500_mmu.c | 2 +- arch/powerpc/kvm/e500_mmu_host.c | 8 +- arch/powerpc/kvm/emulate_loadstore.c | 746 +++++++++---------------------- arch/powerpc/kvm/powerpc.c | 299 ++++++++++--- 24 files changed, 628 insertions(+), 726 deletions(-)