diff mbox series

[iwl-next,v1] ice: Remove ndo_get_phys_port_name

Message ID 20240308105842.141723-1-dariusz.aftanski@linux.intel.com
State Accepted
Delegated to: Anthony Nguyen
Headers show
Series [iwl-next,v1] ice: Remove ndo_get_phys_port_name | expand

Commit Message

Dariusz Aftanski March 8, 2024, 10:58 a.m. UTC 
ndo_get_phys_port_name is never actually used, as in switchdev
devklink is always being created.

Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Signed-off-by: Dariusz Aftanski <dariusz.aftanski@linux.intel.com>
---
 drivers/net/ethernet/intel/ice/ice_repr.c | 34 -----------------------
 1 file changed, 34 deletions(-)

Comments

Simon Horman March 11, 2024, 9:21 a.m. UTC | #1 
On Fri, Mar 08, 2024 at 11:58:42AM +0100, Dariusz Aftanski wrote:
> ndo_get_phys_port_name is never actually used, as in switchdev
> devklink is always being created.
> 
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Signed-off-by: Dariusz Aftanski <dariusz.aftanski@linux.intel.com>

Reviewed-by: Simon Horman <horms@kernel.org>

...
Buvaneswaran, Sujai April 12, 2024, 10:06 a.m. UTC | #2 
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Dariusz Aftanski
> Sent: Friday, March 8, 2024 4:29 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org; Dariusz Aftanski
> <dariusz.aftanski@linux.intel.com>; Michal Swiatkowski
> <michal.swiatkowski@linux.intel.com>
> Subject: [Intel-wired-lan] [iwl-next v1] ice: Remove
> ndo_get_phys_port_name
> 
> ndo_get_phys_port_name is never actually used, as in switchdev devklink is
> always being created.
> 
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Signed-off-by: Dariusz Aftanski <dariusz.aftanski@linux.intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_repr.c | 34 -----------------------
>  1 file changed, 34 deletions(-)
> 
Tested-by: Sujai Buvaneswaran <sujai.buvaneswaran@intel.com>
Jiri Pirko April 12, 2024, 3:14 p.m. UTC | #3 
Fri, Mar 08, 2024 at 11:58:42AM CET, dariusz.aftanski@linux.intel.com wrote:
>ndo_get_phys_port_name is never actually used, as in switchdev
>devklink is always being created.
>
>Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
>Signed-off-by: Dariusz Aftanski <dariusz.aftanski@linux.intel.com>

Reviewed-by: Jiri Pirko <jiri@nvidia.com>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/intel/ice/ice_repr.c b/drivers/net/ethernet/intel/ice/ice_repr.c
index 5f30fb131f74..1f2242a4990e 100644
--- a/drivers/net/ethernet/intel/ice/ice_repr.c
+++ b/drivers/net/ethernet/intel/ice/ice_repr.c
@@ -8,39 +8,6 @@ 
 #include "ice_tc_lib.h"
 #include "ice_dcb_lib.h"
 
-/**
- * ice_repr_get_sw_port_id - get port ID associated with representor
- * @repr: pointer to port representor
- */
-static int ice_repr_get_sw_port_id(struct ice_repr *repr)
-{
-	return repr->src_vsi->back->hw.port_info->lport;
-}
-
-/**
- * ice_repr_get_phys_port_name - get phys port name
- * @netdev: pointer to port representor netdev
- * @buf: write here port name
- * @len: max length of buf
- */
-static int
-ice_repr_get_phys_port_name(struct net_device *netdev, char *buf, size_t len)
-{
-	struct ice_netdev_priv *np = netdev_priv(netdev);
-	struct ice_repr *repr = np->repr;
-	int res;
-
-	/* Devlink port is registered and devlink core is taking care of name formatting. */
-	if (repr->vf->devlink_port.devlink)
-		return -EOPNOTSUPP;
-
-	res = snprintf(buf, len, "pf%dvfr%d", ice_repr_get_sw_port_id(repr),
-		       repr->id);
-	if (res <= 0)
-		return -EOPNOTSUPP;
-	return 0;
-}
-
 /**
  * ice_repr_get_stats64 - get VF stats for VFPR use
  * @netdev: pointer to port representor netdev
@@ -240,7 +207,6 @@  ice_repr_setup_tc(struct net_device *netdev, enum tc_setup_type type,
 }
 
 static const struct net_device_ops ice_repr_netdev_ops = {
-	.ndo_get_phys_port_name = ice_repr_get_phys_port_name,
 	.ndo_get_stats64 = ice_repr_get_stats64,
 	.ndo_open = ice_repr_open,
 	.ndo_stop = ice_repr_stop,