| Message ID | 20240305003707.55507-1-jesse.brandeburg@intel.com |
|---|---|
| State | Accepted |
| Delegated to: | Anthony Nguyen |
| Headers | show |
| Series | [iwl-net,v1] ice: fix typo in assignment | expand |
On Mon, Mar 04, 2024 at 04:37:07PM -0800, Jesse Brandeburg wrote: > Fix an obviously incorrect assignment, created with a typo or cut-n-paste > error. > > Fixes: 5995ef88e3a8 ("ice: realloc VSI stats arrays") > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> Reviewed-by: Simon Horman <horms@kernel.org>
Dear Jesse, Thank you for your patch. Am 05.03.24 um 01:37 schrieb Jesse Brandeburg: > Fix an obviously incorrect assignment, created with a typo or cut-n-paste > error. It’s probably just me, but with these one letter typos I still have to search the diff two or three times to spot the typo. Maybe even use (next time) as commit message summary: ice: Assign tx ring stats value to tx stats and not rx ones > Fixes: 5995ef88e3a8 ("ice: realloc VSI stats arrays") > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> > --- > drivers/net/ethernet/intel/ice/ice_lib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c > index 097bf8fd6bf0..fc23dbe302b4 100644 > --- a/drivers/net/ethernet/intel/ice/ice_lib.c > +++ b/drivers/net/ethernet/intel/ice/ice_lib.c > @@ -3192,7 +3192,7 @@ ice_vsi_realloc_stat_arrays(struct ice_vsi *vsi) > } > } > > - tx_ring_stats = vsi_stat->rx_ring_stats; > + tx_ring_stats = vsi_stat->tx_ring_stats; > vsi_stat->tx_ring_stats = > krealloc_array(vsi_stat->tx_ring_stats, req_txq, > sizeof(*vsi_stat->tx_ring_stats), > > base-commit: 948abb59ebd3892c425165efd8fb2f5954db8de7 Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> Kind regards, Paul
diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c index 097bf8fd6bf0..fc23dbe302b4 100644 --- a/drivers/net/ethernet/intel/ice/ice_lib.c +++ b/drivers/net/ethernet/intel/ice/ice_lib.c @@ -3192,7 +3192,7 @@ ice_vsi_realloc_stat_arrays(struct ice_vsi *vsi) } } - tx_ring_stats = vsi_stat->rx_ring_stats; + tx_ring_stats = vsi_stat->tx_ring_stats; vsi_stat->tx_ring_stats = krealloc_array(vsi_stat->tx_ring_stats, req_txq, sizeof(*vsi_stat->tx_ring_stats),
Fix an obviously incorrect assignment, created with a typo or cut-n-paste error. Fixes: 5995ef88e3a8 ("ice: realloc VSI stats arrays") Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/intel/ice/ice_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 948abb59ebd3892c425165efd8fb2f5954db8de7