| Message ID | 20221014084537.2578025-1-kamil.maziarz@intel.com |
|---|---|
| State | Accepted |
| Delegated to: | Anthony Nguyen |
| Headers | show |
| Series | [net,v1] iavf: Fix VF driver counting VLAN 0 filters | expand |
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Kamil > Maziarz > Sent: Friday, October 14, 2022 10:46 AM > To: intel-wired-lan@lists.osuosl.org > Cc: Jaron, MichalX <michalx.jaron@intel.com>; Patynowski, PrzemyslawX > <przemyslawx.patynowski@intel.com>; Maziarz, Kamil > <kamil.maziarz@intel.com> > Subject: [Intel-wired-lan] [PATCH net v1] iavf: Fix VF driver counting VLAN 0 filters > > From: Michal Jaron <michalx.jaron@intel.com> > > VF driver mistakenly counts VLAN 0 filters, when no PF driver counts them. > Do not count VLAN 0 filters, when VLAN_V2 is engaged. > Counting those filters in, will affect filters size by -1, when sending batched VLAN > addition message. > > Fixes: 968996c070ef ("iavf: Fix VLAN_V2 addition/rejection") > Signed-off-by: Przemyslaw Patynowski <przemyslawx.patynowski@intel.com> > Signed-off-by: Michal Jaron <michalx.jaron@intel.com> > Signed-off-by: Kamil Maziarz <kamil.maziarz@intel.com> > --- > drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c > b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c > index 5a9e6563923e..24a701fd140e 100644 > --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c > +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c index 5a9e6563923e..24a701fd140e 100644 --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c @@ -2438,6 +2438,8 @@ void iavf_virtchnl_completion(struct iavf_adapter *adapter, list_for_each_entry(f, &adapter->vlan_filter_list, list) { if (f->is_new_vlan) { f->is_new_vlan = false; + if (!f->vlan.vid) + continue; if (f->vlan.tpid == ETH_P_8021Q) set_bit(f->vlan.vid, adapter->vsi.active_cvlans);