diff mbox series

[RESEND,net-next] ice: use eth_broadcast_addr() to set broadcast address

Message ID 20220518212759.2444376-1-anthony.l.nguyen@intel.com
State Accepted
Delegated to: Anthony Nguyen
Headers show
Series [RESEND,net-next] ice: use eth_broadcast_addr() to set broadcast address | expand

Commit Message

Tony Nguyen May 18, 2022, 9:27 p.m. UTC
From: Lu Wei <luwei32@huawei.com>

Use eth_broadcast_addr() to set broadcast address instead of memset().

Signed-off-by: Lu Wei <luwei32@huawei.com>
---
Resending due to mail issues with Intel Wired LAN

 drivers/net/ethernet/intel/ice/ice_tc_lib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

G, GurucharanX June 17, 2022, 6:45 a.m. UTC | #1
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Tony Nguyen
> Sent: Thursday, May 19, 2022 2:58 AM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Lu Wei <luwei32@huawei.com>
> Subject: [Intel-wired-lan] [PATCH RESEND net-next] ice: use
> eth_broadcast_addr() to set broadcast address
> 
> From: Lu Wei <luwei32@huawei.com>
> 
> Use eth_broadcast_addr() to set broadcast address instead of memset().
> 
> Signed-off-by: Lu Wei <luwei32@huawei.com>
> ---
> Resending due to mail issues with Intel Wired LAN
> 
>  drivers/net/ethernet/intel/ice/ice_tc_lib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
diff mbox series

Patch

diff --git a/drivers/net/ethernet/intel/ice/ice_tc_lib.c b/drivers/net/ethernet/intel/ice/ice_tc_lib.c
index 847b19f5ac0e..9a2050e98cce 100644
--- a/drivers/net/ethernet/intel/ice/ice_tc_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_tc_lib.c
@@ -1415,7 +1415,7 @@  ice_handle_tclass_action(struct ice_vsi *vsi,
 			   ICE_TC_FLWR_FIELD_ENC_DST_MAC)) {
 		ether_addr_copy(fltr->outer_headers.l2_key.dst_mac,
 				vsi->netdev->dev_addr);
-		memset(fltr->outer_headers.l2_mask.dst_mac, 0xff, ETH_ALEN);
+		eth_broadcast_addr(fltr->outer_headers.l2_mask.dst_mac);
 	}
 
 	/* validate specified dest MAC address, make sure either it belongs to