| Message ID | 20211123171840.157471-8-alexandr.lobakin@intel.com |
|---|---|
| State | Accepted |
| Delegated to: | Anthony Nguyen |
| Headers | show |
| Series | intel: switch to napi_build_skb() | expand |
On 11/23/2021 19:18, Alexander Lobakin wrote: > napi_build_skb() reuses per-cpu NAPI skbuff_head cache in order > to save some cycles on freeing/allocating skbuff_heads on every > new Rx or completed Tx. > igc driver runs Tx completion polling cycle right before the Rx > one and uses napi_consume_skb() to feed the cache with skbuff_heads > of completed entries, so it's never empty and always warm at that > moment. Switch to the napi_build_skb() to relax mm pressure on > heavy Rx. > > Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com> > Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com> > --- > drivers/net/ethernet/intel/igc/igc_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Tested-by: Nechama Kraus <nechamax.kraus@linux.intel.com>
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c index 8e448288ee26..8b13a61ea5c9 100644 --- a/drivers/net/ethernet/intel/igc/igc_main.c +++ b/drivers/net/ethernet/intel/igc/igc_main.c @@ -1729,7 +1729,7 @@ static struct sk_buff *igc_build_skb(struct igc_ring *rx_ring, net_prefetch(va); /* build an skb around the page buffer */ - skb = build_skb(va - IGC_SKB_PAD, truesize); + skb = napi_build_skb(va - IGC_SKB_PAD, truesize); if (unlikely(!skb)) return NULL;