| Message ID | 20211114060222.231075-1-wangborong@cdjrlc.com |
|---|---|
| State | Accepted |
| Delegated to: | Anthony Nguyen |
| Headers | show |
| Series | igb: remove never changed variable `ret_val' | expand |
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Jason Wang > Sent: Sunday, November 14, 2021 11:32 AM > To: kuba@kernel.org > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Jason Wang > <wangborong@cdjrlc.com>; intel-wired-lan@lists.osuosl.org; > davem@davemloft.net > Subject: [Intel-wired-lan] [PATCH] igb: remove never changed variable `ret_val' > > The variable used for return status in `igb_write_xmdio_reg' function is never > changed and this function is just need return 0. Thus, the `ret_val' can be > removed and return 0 at the end of the `igb_write_xmdio_reg' function. > > Signed-off-by: Jason Wang <wangborong@cdjrlc.com> > --- > drivers/net/ethernet/intel/igb/e1000_i210.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
diff --git a/drivers/net/ethernet/intel/igb/e1000_i210.c b/drivers/net/ethernet/intel/igb/e1000_i210.c index 9265901455cd..b9b9d35494d2 100644 --- a/drivers/net/ethernet/intel/igb/e1000_i210.c +++ b/drivers/net/ethernet/intel/igb/e1000_i210.c @@ -792,7 +792,6 @@ s32 igb_write_xmdio_reg(struct e1000_hw *hw, u16 addr, u8 dev_addr, u16 data) **/ s32 igb_init_nvm_params_i210(struct e1000_hw *hw) { - s32 ret_val = 0; struct e1000_nvm_info *nvm = &hw->nvm; nvm->ops.acquire = igb_acquire_nvm_i210; @@ -813,7 +812,7 @@ s32 igb_init_nvm_params_i210(struct e1000_hw *hw) nvm->ops.validate = NULL; nvm->ops.update = NULL; } - return ret_val; + return 0; } /**
The variable used for return status in `igb_write_xmdio_reg' function is never changed and this function is just need return 0. Thus, the `ret_val' can be removed and return 0 at the end of the `igb_write_xmdio_reg' function. Signed-off-by: Jason Wang <wangborong@cdjrlc.com> --- drivers/net/ethernet/intel/igb/e1000_i210.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)