| Message ID | 20210326184343.133396-2-arkadiusz.kubalewski@intel.com |
|---|---|
| State | Accepted |
| Delegated to: | Anthony Nguyen |
| Headers | show |
| Series | [net] i40e: Fix sparse error: uninitialized symbol 'ring' | expand |
>-----Original Message----- >From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of >Arkadiusz Kubalewski >Sent: Friday, March 26, 2021 11:44 AM >To: intel-wired-lan@lists.osuosl.org >Cc: Loktionov, Aleksandr <aleksandr.loktionov@intel.com> >Subject: [Intel-wired-lan] [PATCH net] i40e: Fix sparse error: uninitialized symbol >'ring' > >Init pointer with NULL in default switch case statement. > >Previously the error was produced when compiling against sparse. >i40e_debugfs.c:582 i40e_dbg_dump_desc() error: uninitialized symbol 'ring'. > >Fixes: 44ea803e2fa7 ("i40e: introduce new dump desc XDP command") >Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com> >Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com> >--- > drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 3 +++ > 1 file changed, 3 insertions(+) > Tested-by: Dave Switzer <david.switzer@intel.com>
diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c index d7c13ca..d627b59 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c +++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c @@ -578,6 +578,9 @@ static void i40e_dbg_dump_desc(int cnt, int vsi_seid, int ring_id, int desc_n, case RING_TYPE_XDP: ring = kmemdup(vsi->xdp_rings[ring_id], sizeof(*ring), GFP_KERNEL); break; + default: + ring = NULL; + break; } if (!ring) return;
Init pointer with NULL in default switch case statement. Previously the error was produced when compiling against sparse. i40e_debugfs.c:582 i40e_dbg_dump_desc() error: uninitialized symbol 'ring'. Fixes: 44ea803e2fa7 ("i40e: introduce new dump desc XDP command") Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com> Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com> --- drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 3 +++ 1 file changed, 3 insertions(+) base-commit: ca4303103f33952646218db4e0869e6f6aa1c840