Message ID | 20200927194920.621578351@linutronix.de |
---|---|
State | Awaiting Upstream |
Headers | show
Return-Path: <intel-wired-lan-bounces@osuosl.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=EcGTRs6k; dkim=fail reason="signature verification failed" header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=hWtxjUGi; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4C07dl4x7Xz9sSs for <incoming@patchwork.ozlabs.org>; Mon, 28 Sep 2020 13:43:07 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 9646C20377; Mon, 28 Sep 2020 03:43:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GoIhhaICZDAQ; Mon, 28 Sep 2020 03:42:58 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id C5EE820410; Mon, 28 Sep 2020 03:42:43 +0000 (UTC) X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 224051BF95E for <intel-wired-lan@lists.osuosl.org>; Sun, 27 Sep 2020 19:57:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 1E89085631 for <intel-wired-lan@lists.osuosl.org>; Sun, 27 Sep 2020 19:57:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xY4Yzy92CJvY for <intel-wired-lan@lists.osuosl.org>; Sun, 27 Sep 2020 19:57:17 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 521738508E for <intel-wired-lan@lists.osuosl.org>; Sun, 27 Sep 2020 19:57:17 +0000 (UTC) Message-Id: <20200927194920.621578351@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1601236635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: references:references; bh=GmRWTTg+MNTA0DaNDIlEXevW16R3g516zjE3yhxS5XQ=; b=EcGTRs6kb2RDfe2vyrf2+4PlTt9+1DxF8xx4TukwbvrjHvPN/bK00Rh9OwV+XrLtzQQiKp 5YkzTiEqP+CUpeMVzxkK770Zn2LqxoGqekXuL4WpC03EEpLfqHHNc+yaATldWUENSYX8uK Fpwww0Eg/kIenfNeKQFWF/4R8zudM55O/i8cF0E+53SJuBr+zlRE42pPnxnUHgpw+PpUuw yxMnpHdK1H6DVKGV2jJT0QVET6zb9XNaf9xXe3Q8emDzLnwU/sRViGNhTqD5hInVKQ4bkZ M6MnBlUz1M+wQzG84vC+cHQ2X8UeSNGr7HJYylvjMNB9y+F5NNaQbmd/ZsW5mA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1601236635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: references:references; bh=GmRWTTg+MNTA0DaNDIlEXevW16R3g516zjE3yhxS5XQ=; b=hWtxjUGi2gFRAx8XtEhLw5uROxf7tPRASC/GDVwAj2gS8xyWHVw9Vv65j/9pO1/TwqLZ27 FQxcdeBMHBK0AYBw== Date: Sun, 27 Sep 2020 21:48:54 +0200 From: Thomas Gleixner <tglx@linutronix.de> To: LKML <linux-kernel@vger.kernel.org> References: <20200927194846.045411263@linutronix.de> MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 28 Sep 2020 03:42:39 +0000 Subject: [Intel-wired-lan] [patch 08/35] net: e100: Remove in_interrupt() usage and pointless GFP_ATOMIC allocation X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development <intel-wired-lan.osuosl.org> List-Unsubscribe: <https://lists.osuosl.org/mailman/options/intel-wired-lan>, <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe> List-Archive: <http://lists.osuosl.org/pipermail/intel-wired-lan/> List-Post: <mailto:intel-wired-lan@osuosl.org> List-Help: <mailto:intel-wired-lan-request@osuosl.org?subject=help> List-Subscribe: <https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe> Cc: Andrew Lunn <andrew@lunn.ch>, Emmanuel Grumbach <emmanuel.grumbach@intel.com>, linux-doc@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>, Chris Snook <chris.snook@gmail.com>, Sebastian Andrzej Siewior <bigeasy@linutronix.de>, Arend van Spriel <arend.vanspriel@broadcom.com>, Govindarajulu Varadarajan <_govind@gmx.com>, Vishal Kulkarni <vishal@chelsio.com>, Luca Coelho <luciano.coelho@intel.com>, Edward Cree <ecree@solarflare.com>, libertas-dev@lists.infradead.org, brcm80211-dev-list@cypress.com, brcm80211-dev-list.pdl@broadcom.com, Ping-Ke Shih <pkshih@realtek.com>, Johannes Berg <johannes.berg@intel.com>, Jonathan Corbet <corbet@lwn.net>, Mauro Carvalho Chehab <mchehab+huawei@kernel.org>, Intel Linux Wireless <linuxwifi@intel.com>, Russell King <linux@armlinux.org.uk>, Matthew Wilcox <willy@infradead.org>, Heiner Kallweit <hkallweit1@gmail.com>, intel-wired-lan@lists.osuosl.org, Jakub Kicinski <kuba@kernel.org>, Martin Habets <mhabets@solarflare.com>, Ulrich Kunitz <kune@deine-taler.de>, Jay Cliburn <jcliburn@gmail.com>, Paul McKenney <paulmck@kernel.org>, Stanislaw Gruszka <stf_xl@wp.pl>, Jouni Malinen <j@w1.fi>, Hante Meuleman <hante.meuleman@broadcom.com>, Pascal Terjan <pterjan@google.com>, Linus Torvalds <torvalds@linuxfoundation.org>, Amitkumar Karwar <amitkarwar@gmail.com>, Wright Feng <wright.feng@cypress.com>, Daniel Drake <dsd@gentoo.org>, Pensando Drivers <drivers@pensando.io>, Kalle Valo <kvalo@codeaurora.org>, Franky Lin <franky.lin@broadcom.com>, Solarflare linux maintainers <linux-net-drivers@solarflare.com>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, Chi-Hsien Lin <chi-hsien.lin@cypress.com>, Xinming Hu <huxinming820@gmail.com>, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Ganapathi Bhat <ganapathi.bhat@nxp.com>, Stanislav Yakovlev <stas.yakovlev@gmail.com>, Jon Mason <jdmason@kudzu.us>, Shannon Nelson <snelson@pensando.io>, Dave Miller <davem@davemloft.net>, Luc Van Oostenryck <luc.vanoostenryck@gmail.com>, Christian Benvenuti <benve@cisco.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" <intel-wired-lan-bounces@osuosl.org> |
Series |
net: in_interrupt() cleanup and fixes
|
expand
|
--- a/drivers/net/ethernet/intel/e100.c +++ b/drivers/net/ethernet/intel/e100.c @@ -1531,7 +1531,7 @@ static int e100_hw_init(struct nic *nic) e100_hw_reset(nic); netif_err(nic, hw, nic->netdev, "e100_hw_init\n"); - if (!in_interrupt() && (err = e100_self_test(nic))) + if ((err = e100_self_test(nic))) return err; if ((err = e100_phy_init(nic))) @@ -2155,7 +2155,7 @@ static int e100_rx_alloc_list(struct nic nic->rx_to_use = nic->rx_to_clean = NULL; nic->ru_running = RU_UNINITIALIZED; - if (!(nic->rxs = kcalloc(count, sizeof(struct rx), GFP_ATOMIC))) + if (!(nic->rxs = kcalloc(count, sizeof(struct rx), GFP_KERNEL))) return -ENOMEM; for (rx = nic->rxs, i = 0; i < count; rx++, i++) {