From patchwork Fri Sep 25 22:24:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jesse Brandeburg X-Patchwork-Id: 1371629 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=LnyaJYB4; dkim-atps=neutral Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bymgp3WRMz9sTN for ; Sat, 26 Sep 2020 08:25:10 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id AA55187693; Fri, 25 Sep 2020 22:25:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Pdcs5ISC5hza; Fri, 25 Sep 2020 22:25:06 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 5635087692; Fri, 25 Sep 2020 22:25:06 +0000 (UTC) X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 0E9061BF349 for ; Fri, 25 Sep 2020 22:25:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 09C3786D1D for ; Fri, 25 Sep 2020 22:25:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IIepGL1OrWWl for ; Fri, 25 Sep 2020 22:25:03 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 516C686D10 for ; Fri, 25 Sep 2020 22:25:03 +0000 (UTC) Received: by mail-pj1-f67.google.com with SMTP id md22so127033pjb.0 for ; Fri, 25 Sep 2020 15:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jmTFoZ5nOIect56+iNWMt+NdDBec3iDrAHMLNIdLP7U=; b=LnyaJYB4PM74e71DGuPy+9I3RH6KMsZW2pdlfN9D6esb+S7mgAi2fgOcaZxPP/JA0P OBzyYQwJao3B05JwZAeDFVO9ruIY/o7SBvdeQZpGdDPtal55otdYPzzm56svp5lVTZCs fem1OEr+AVQ7z8KPsBKGzfIe4hLIXlUfJJbPToNzfMPcpT3AC35kFfvYKHQ+1yBhm18j UjRBSATASzURXGJW9zhY1Od0XsgAH3d78v/eFkDhK22u+VXqcdUhv38kUFJoz5TUC92/ 0EazYU9tQR8B8RnH6oWrsAF4w6gaAhaRS9hxzD44MVErn2pwNLQlWpFQauy+qAC1VFAu a6Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jmTFoZ5nOIect56+iNWMt+NdDBec3iDrAHMLNIdLP7U=; b=tU7hwRz2v1g05lYR9uu0S90cmR1+OyMjji/XGqEewh9x8PGd7B5n6029aB93e8n+UW qHdOGBR7M3YT8WZiW91f/JByEcf8L9SLYXyQdpENH5ya1nQlTRHwxEigoTz9RypP2aT6 gETrwcJw8GWk25DpAeQA9IbNZZynT1pPT1wooN+5KQ412F8rKNygf1KIrb2giAwmM+9z iG0SA4GJhGlMkM6zSNSuPVDO4scyOa3ZtMAe5Q7p0D84DjgK4t49D73LHOYD1ET9cgJE MtZf+UIAx0FSlV+ib15QAJFKdgo2YL4P2Z/ArXTWfpGe00t/C7dEgYe9CYxbpKrOVxZ4 q68Q== X-Gm-Message-State: AOAM531L9lJn3zrJ3T5KzHoU/YVWMuM+pyWaIFt5fXd3rU8uu1L850pJ gTGH0/2Sh8zvxOq5aS2M2Bw= X-Google-Smtp-Source: ABdhPJx3tp2IZEa0Sl+fF7JkL3zQp5nvzOMmU2LTVIO/uOQqnW4EKxQ+cmb4olmdbwsjUEy0yRRnbw== X-Received: by 2002:a17:90a:14a4:: with SMTP id k33mr608162pja.236.1601072702847; Fri, 25 Sep 2020 15:25:02 -0700 (PDT) Received: from jesse-ThinkPad-T570.lan (50-39-107-76.bvtn.or.frontiernet.net. [50.39.107.76]) by smtp.gmail.com with ESMTPSA id q15sm169343pje.29.2020.09.25.15.25.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2020 15:25:01 -0700 (PDT) From: Jesse Brandeburg To: netdev@vger.kernel.org Date: Fri, 25 Sep 2020 15:24:40 -0700 Message-Id: <20200925222445.74531-5-jesse.brandeburg@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200925222445.74531-1-jesse.brandeburg@gmail.com> References: <20200925222445.74531-1-jesse.brandeburg@gmail.com> MIME-Version: 1.0 Subject: [Intel-wired-lan] [PATCH net-next v3 4/9] drivers/net/ethernet: rid ethernet of no-prototype warnings X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-wired-lan@lists.osuosl.org Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" From: Jesse Brandeburg The W=1 builds showed a few files exporting functions (non-static) that were not prototyped. What actually happened is that there were prototypes, but the include file was forgotten in the implementation file. Add the include file and remove the warnings. Fixed Warnings: drivers/net/ethernet/cavium/liquidio/cn68xx_device.c:124:5: warning: no previous prototype for ‘lio_setup_cn68xx_octeon_device’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:159:1: warning: no previous prototype for ‘octeon_pci_read_core_mem’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:168:1: warning: no previous prototype for ‘octeon_pci_write_core_mem’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:176:5: warning: no previous prototype for ‘octeon_read_device_mem64’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:185:5: warning: no previous prototype for ‘octeon_read_device_mem32’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:194:6: warning: no previous prototype for ‘octeon_write_device_mem32’ [-Wmissing-prototypes] drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c:453:6: warning: no previous prototype for ‘hclge_dcb_ops_set’ [-Wmissing-prototypes] Signed-off-by: Jesse Brandeburg --- v3: add warnings detail v2: first non-rfc version Full list of warnings: drivers/net/ethernet/cavium/liquidio/cn68xx_device.c:124:5: warning: no previous prototype for ‘lio_setup_cn68xx_octeon_device’ [-Wmissing-prototypes] 124 | int lio_setup_cn68xx_octeon_device(struct octeon_device *oct) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:159:1: warning: no previous prototype for ‘octeon_pci_read_core_mem’ [-Wmissing-prototypes] 159 | octeon_pci_read_core_mem(struct octeon_device *oct, | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:168:1: warning: no previous prototype for ‘octeon_pci_write_core_mem’ [-Wmissing-prototypes] 168 | octeon_pci_write_core_mem(struct octeon_device *oct, | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:176:5: warning: no previous prototype for ‘octeon_read_device_mem64’ [-Wmissing-prototypes] 176 | u64 octeon_read_device_mem64(struct octeon_device *oct, u64 coreaddr) | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:185:5: warning: no previous prototype for ‘octeon_read_device_mem32’ [-Wmissing-prototypes] 185 | u32 octeon_read_device_mem32(struct octeon_device *oct, u64 coreaddr) | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:194:6: warning: no previous prototype for ‘octeon_write_device_mem32’ [-Wmissing-prototypes] 194 | void octeon_write_device_mem32(struct octeon_device *oct, u64 coreaddr, | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c:453:6: warning: no previous prototype for ‘hclge_dcb_ops_set’ [-Wmissing-prototypes] 453 | void hclge_dcb_ops_set(struct hclge_dev *hdev) | ^~~~~~~~~~~~~~~~~ --- drivers/net/ethernet/cavium/liquidio/cn68xx_device.c | 1 + drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c b/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c index cd5d5d6e7e5e..2a6d1cadac9e 100644 --- a/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c +++ b/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c @@ -25,6 +25,7 @@ #include "octeon_main.h" #include "cn66xx_regs.h" #include "cn66xx_device.h" +#include "cn68xx_device.h" #include "cn68xx_regs.h" #include "cn68xx_device.h" diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c index f990f6915226..3606240025a8 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c @@ -4,6 +4,7 @@ #include "hclge_main.h" #include "hclge_dcb.h" #include "hclge_tm.h" +#include "hclge_dcb.h" #include "hnae3.h" #define BW_PERCENT 100