| Message ID | 20200318230102.36952-3-andre.guedes@intel.com |
|---|---|
| State | Accepted |
| Delegated to: | Jeff Kirsher |
| Headers | show |
| Series | igc: Refactor MAC address filtering code | expand |
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Andre Guedes > Sent: Wednesday, March 18, 2020 4:01 PM > To: intel-wired-lan@lists.osuosl.org > Subject: [Intel-wired-lan] [PATCH 02/12] igc: Check unsupported flag in > igc_add_mac_filter() > > The IGC_MAC_STATE_SRC_ADDR flags is not supported by igc_add_mac_ > filter() so this patch adds a check for it and returns -ENOTSUPP > in case it is set. > > Signed-off-by: Andre Guedes <andre.guedes@intel.com> > --- > drivers/net/ethernet/intel/igc/igc_main.c | 2 ++ > 1 file changed, 2 insertions(+)
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Brown, Aaron F > Sent: Tuesday, March 31, 2020 12:59 PM > To: Guedes, Andre <andre.guedes@intel.com>; intel-wired-lan@lists.osuosl.org > Subject: Re: [Intel-wired-lan] [PATCH 02/12] igc: Check unsupported flag in > igc_add_mac_filter() > > > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > > Andre Guedes > > Sent: Wednesday, March 18, 2020 4:01 PM > > To: intel-wired-lan@lists.osuosl.org > > Subject: [Intel-wired-lan] [PATCH 02/12] igc: Check unsupported flag in > > igc_add_mac_filter() > > > > The IGC_MAC_STATE_SRC_ADDR flags is not supported by igc_add_mac_ > > filter() so this patch adds a check for it and returns -ENOTSUPP > > in case it is set. > > > > Signed-off-by: Andre Guedes <andre.guedes@intel.com> > > --- > > drivers/net/ethernet/intel/igc/igc_main.c | 2 ++ > > 1 file changed, 2 insertions(+) Tested-by: Aaron Brown <aaron.f.brown@intel.com>
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c index 107e9f86bd0a..5360d73d9c63 100644 --- a/drivers/net/ethernet/intel/igc/igc_main.c +++ b/drivers/net/ethernet/intel/igc/igc_main.c @@ -2201,6 +2201,8 @@ static int igc_add_mac_filter(struct igc_adapter *adapter, const u8 *addr, if (is_zero_ether_addr(addr)) return -EINVAL; + if (flags & IGC_MAC_STATE_SRC_ADDR) + return -ENOTSUPP; /* Search for the first empty entry in the MAC table. * Do not touch entries at the end of the table reserved for the VF MAC
The IGC_MAC_STATE_SRC_ADDR flags is not supported by igc_add_mac_ filter() so this patch adds a check for it and returns -ENOTSUPP in case it is set. Signed-off-by: Andre Guedes <andre.guedes@intel.com> --- drivers/net/ethernet/intel/igc/igc_main.c | 2 ++ 1 file changed, 2 insertions(+)