diff mbox series

[RFC] ixgbe: ixgbe_get_completion_timeout() can be static

Message ID 20180721055327.GA30259@lkp-wsm-ep1
State RFC
Headers show
Series [RFC] ixgbe: ixgbe_get_completion_timeout() can be static | expand

Commit Message

kbuild test robot July 21, 2018, 5:53 a.m. UTC
Fixes: 23f3effc3f69 ("ixgbe: Refactor queue disable logic to take completion time into account")
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
 ixgbe_main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexander H Duyck July 23, 2018, 4:24 p.m. UTC | #1
On Fri, Jul 20, 2018 at 10:53 PM, kbuild test robot
<fengguang.wu@intel.com> wrote:
>
> Fixes: 23f3effc3f69 ("ixgbe: Refactor queue disable logic to take completion time into account")
> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>

Jeff do you think you could fold this into the current completion timeout patch?

Thanks.

- Alex
Kirsher, Jeffrey T July 23, 2018, 5:35 p.m. UTC | #2
On Mon, 2018-07-23 at 09:24 -0700, Alexander Duyck wrote:
> On Fri, Jul 20, 2018 at 10:53 PM, kbuild test robot
> <fengguang.wu@intel.com> wrote:
> > 
> > Fixes: 23f3effc3f69 ("ixgbe: Refactor queue disable logic to take
> > completion time into account")
> > Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
> 
> Jeff do you think you could fold this into the current completion
> timeout patch?

Yes, I can do that.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index d4395f1..e3fac6a 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -5605,7 +5605,7 @@  void ixgbe_up(struct ixgbe_adapter *adapter)
 	ixgbe_up_complete(adapter);
 }
 
-unsigned long ixgbe_get_completion_timeout(struct ixgbe_adapter *adapter)
+static unsigned long ixgbe_get_completion_timeout(struct ixgbe_adapter *adapter)
 {
 	u16 devctl2;