Message ID | 20180403211619.7880.24524.stgit@ahduyck-green-test.jf.intel.com |
---|---|
State | Accepted |
Delegated to: | Jeff Kirsher |
Headers | show |
Series | Clean-up macvlan offloading | expand |
> -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On > Behalf Of Alexander Duyck > Sent: Tuesday, April 3, 2018 2:16 PM > To: intel-wired-lan@lists.osuosl.org; Kirsher, Jeffrey T > <jeffrey.t.kirsher@intel.com> > Cc: netdev@vger.kernel.org > Subject: [Intel-wired-lan] [iwl next-queue PATCH 05/10] macvlan: > macvlan_count_rx shouldn't be static inline AND extern > > It doesn't make sense to define macvlan_count_rx as a static inline and then > add a forward declaration after that as an extern. I am dropping the extern > declaration since it seems like it is something that likely got missed when the > function was made an inline. > > Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> > --- > include/linux/if_macvlan.h | 4 ---- > 1 file changed, 4 deletions(-) Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
diff --git a/include/linux/if_macvlan.h b/include/linux/if_macvlan.h index c5106ce..80089d6 100644 --- a/include/linux/if_macvlan.h +++ b/include/linux/if_macvlan.h @@ -61,10 +61,6 @@ extern int macvlan_common_newlink(struct net *src_net, struct net_device *dev, struct nlattr *tb[], struct nlattr *data[], struct netlink_ext_ack *extack); -extern void macvlan_count_rx(const struct macvlan_dev *vlan, - unsigned int len, bool success, - bool multicast); - extern void macvlan_dellink(struct net_device *dev, struct list_head *head); extern int macvlan_link_register(struct rtnl_link_ops *ops);
It doesn't make sense to define macvlan_count_rx as a static inline and then add a forward declaration after that as an extern. I am dropping the extern declaration since it seems like it is something that likely got missed when the function was made an inline. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> --- include/linux/if_macvlan.h | 4 ---- 1 file changed, 4 deletions(-)