diff mbox series

[S88,2/8] i40e: Prevent setting link speed on KX_X722

Message ID 20180314181918.21582-2-jeffrey.t.kirsher@intel.com
State Accepted
Delegated to: Jeff Kirsher
Headers show
Series None | expand

Commit Message

Kirsher, Jeffrey T March 14, 2018, 6:19 p.m. UTC
From: Patryk Małek <patryk.malek@intel.com>

Setting link settings on backplane devices shouldn't be allowed.
This patch adds one more device id to the list which we check
that against.

Signed-off-by: Patryk Małek <patryk.malek@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Bowers, AndrewX March 14, 2018, 11:10 p.m. UTC | #1
> -----Original Message-----

> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On

> Behalf Of Jeff Kirsher

> Sent: Wednesday, March 14, 2018 11:19 AM

> To: intel-wired-lan@lists.osuosl.org

> Subject: [Intel-wired-lan] [PATCH S88 2/8] i40e: Prevent setting link speed on

> KX_X722

> 

> From: Patryk Małek <patryk.malek@intel.com>

> 

> Setting link settings on backplane devices shouldn't be allowed.

> This patch adds one more device id to the list which we check that against.

> 

> Signed-off-by: Patryk Małek <patryk.malek@intel.com>

> ---

>  drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3 ++-

>  1 file changed, 2 insertions(+), 1 deletion(-)


Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
index 9bb85daa2c6c..d86d0900dfa9 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
@@ -860,7 +860,8 @@  static int i40e_set_link_ksettings(struct net_device *netdev,
 	if (hw->device_id == I40E_DEV_ID_KX_B ||
 	    hw->device_id == I40E_DEV_ID_KX_C ||
 	    hw->device_id == I40E_DEV_ID_20G_KR2 ||
-	    hw->device_id == I40E_DEV_ID_20G_KR2_A) {
+	    hw->device_id == I40E_DEV_ID_20G_KR2_A ||
+	    hw->device_id == I40E_DEV_ID_KX_X722) {
 		netdev_info(netdev, "Changing settings is not supported on backplane.\n");
 		return -EOPNOTSUPP;
 	}