From patchwork Tue Nov 14 23:51:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matt Turner X-Patchwork-Id: 838075 X-Patchwork-Delegate: jeffrey.t.kirsher@intel.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=osuosl.org (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YxKXRDfr"; dkim-atps=neutral Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yc4WG0JBVz9s83 for ; Wed, 15 Nov 2017 11:09:45 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id BC40686E9A; Wed, 15 Nov 2017 00:09:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tcivlBBIkbh9; Wed, 15 Nov 2017 00:09:32 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 8B77D869B9; Wed, 15 Nov 2017 00:09:32 +0000 (UTC) X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 9434A1C0E6C for ; Tue, 14 Nov 2017 23:51:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 81D5F87230 for ; Tue, 14 Nov 2017 23:51:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6xzlQo2yI2Mo for ; Tue, 14 Nov 2017 23:51:36 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pg0-f65.google.com (mail-pg0-f65.google.com [74.125.83.65]) by whitealder.osuosl.org (Postfix) with ESMTPS id 043F987183 for ; Tue, 14 Nov 2017 23:51:36 +0000 (UTC) Received: by mail-pg0-f65.google.com with SMTP id s2so16590040pge.10 for ; Tue, 14 Nov 2017 15:51:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=A3FgoPTbVP9ygcLm9WhaJW37eXUdlVFAJ4rnoh/0xBI=; b=YxKXRDfrbrXF+2UKx4LNebIkXTfuut7fJIw3cWiWYsLmVDsCIUXkPOX1TguS+DtN0X cUjrT7MWW4RsQ47T232Nx2u7+7I+A27lIPqBlqELUl0+sxmpW7/q8BHY0h1L3WqxwPmI grUV1aO5oOvwvHysPsZb1guM6plRzx9FtsbS/zzA50CCLr4FX35B6WXD9oUlkxkSwVBt ZmxBIFshS6XJuZZU9+5KBa2sAKvyRFOe5CqCJ4pRIeu3IIMPv8BCdN7PnluuV7Cg4/W0 qB1zbPWNFrYiMae2XuB57yMDSSQ62KleYhRUSiPknLdQwFPLrh7u+o18mK/UYj4DqWMr lg+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=A3FgoPTbVP9ygcLm9WhaJW37eXUdlVFAJ4rnoh/0xBI=; b=DZRkEU3WiPZSmPrF6XrwMUc6evjQlgExn8wpe3JztoiiQl0+rZD1ra4eef23pyCbXI c8fD5AA/96quKI/Q9MIPX0U9Czqj1wvFhSDKZnCxeqLqZHjXkfZ90tYfwtCnPf93f8EQ tUOGp5XflB74CDtCPDSHWD5IHTWDbGHUrtbXrcdDFPYKTE/ioeNX13v2FiW+UNi0ztN1 8+5qJ2AHY+yZEC3GB0MlCgMQjK4Mi24gjDuQSYTFNEw4meoQYhV7bLrgjnBs2NsXuX8x KBQlVQyEo/Rx6nkGUudCgYdpKC5+mcee08XHN/zsIudtImmp2zj59NkWMHLkpr2YmAco IrmA== X-Gm-Message-State: AJaThX5eo62vwaDmb6aKTI1hWJcpZg39NXezPHPI9KA0sHHxIw4PFXrr TnFS0BDBphP1sjXWoemA2DvdpC49 X-Google-Smtp-Source: AGs4zMbLyywqnECBYJZPk76sCFH1W/yT7wWeWStzEttazZn0ITF9FoiBTjHlkM3VRovvJ3KIzH/ZJw== X-Received: by 10.84.128.72 with SMTP id 66mr13756809pla.250.1510703495381; Tue, 14 Nov 2017 15:51:35 -0800 (PST) Received: from localhost ([108.161.26.224]) by smtp.gmail.com with ESMTPSA id x188sm27502093pgx.33.2017.11.14.15.51.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Nov 2017 15:51:34 -0800 (PST) From: Matt Turner To: intel-wired-lan@lists.osuosl.org Date: Tue, 14 Nov 2017 15:51:33 -0800 Message-Id: <20171114235133.14755-1-mattst88@gmail.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171107221332.28283-2-mattst88@gmail.com> References: <20171107221332.28283-2-mattst88@gmail.com> Subject: [Intel-wired-lan] [PATCH 2/3] e1000e: Alert the user that C-states will be disabled by enabling jumbo frames X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matt Turner MIME-Version: 1.0 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" From: Matt Turner I personally spent a long time trying to decypher why my CPU would not reach deeper C-states. Let's just tell the next user what's going on. Signed-off-by: Matt Turner Acked-by: Shannon Nelson Tested-by: Aaron Brown --- v2: Per Shannon, put string on one line for easier grepping drivers/net/ethernet/intel/e1000e/netdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index 286d0277284e..31577dad22cb 100644 --- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c @@ -3288,6 +3288,8 @@ static void e1000_configure_rx(struct e1000_adapter *adapter) ew32(RXDCTL(0), rxdctl | 0x3 | BIT(8)); } + dev_info(&adapter->pdev->dev, + "Some CPU C-states have been disabled in order to enable jumbo frames\n"); pm_qos_update_request(&adapter->pm_qos_req, lat); } else { pm_qos_update_request(&adapter->pm_qos_req,