From patchwork Wed Nov 11 17:35:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Dauchy X-Patchwork-Id: 543297 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ozlabs.org (Postfix) with ESMTP id DA1BF141409 for ; Thu, 12 Nov 2015 21:10:21 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 35DE393C75; Thu, 12 Nov 2015 10:10:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wU6-RNjIMz8s; Thu, 12 Nov 2015 10:10:19 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id B0055938D0; Thu, 12 Nov 2015 10:10:18 +0000 (UTC) X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 5FB381C0CB7 for ; Wed, 11 Nov 2015 17:44:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 592958BEF4 for ; Wed, 11 Nov 2015 17:44:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Di6CYP4LbG0F for ; Wed, 11 Nov 2015 17:44:12 +0000 (UTC) X-Greylist: delayed 00:08:42 by SQLgrey-1.7.6 Received: from gandi.net (mail4.gandi.net [217.70.183.210]) by whitealder.osuosl.org (Postfix) with ESMTP id 2D9058BF3F for ; Wed, 11 Nov 2015 17:44:12 +0000 (UTC) Received: from mfiltercorp2.gandi.net (mfiltercorp2.gandi.net [217.70.183.154]) by gandi.net (Postfix) with ESMTP id D6EE3E39FE; Wed, 11 Nov 2015 18:35:28 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfiltercorp2.gandi.net Received: from gandi.net ([IPv6:::ffff:217.70.183.210]) by mfiltercorp2.gandi.net (mfiltercorp2.gandi.net [::ffff:217.70.183.154]) (amavisd-new, port 10024) with ESMTP id 2KSZHGdSs3IA; Wed, 11 Nov 2015 18:35:28 +0100 (CET) Received: from gandi.net (fob.gandi.net [217.70.181.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by gandi.net (Postfix) with ESMTPSA id C9F57E39FD; Wed, 11 Nov 2015 18:35:27 +0100 (CET) Date: Wed, 11 Nov 2015 18:35:27 +0100 From: William Dauchy To: Jeff Kirsher , Emil Tantilov Message-ID: <20151111173527.GA3641@gandi.net> MIME-Version: 1.0 Reply_to: William Dauchy User-Agent: Mutt/1.5.24 (2015-08-30) X-Mailman-Approved-At: Thu, 12 Nov 2015 10:10:17 +0000 Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, davem@davemloft.net Subject: [Intel-wired-lan] regression in ixgbe SFP detection patch X-BeenThere: intel-wired-lan@lists.osuosl.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@lists.osuosl.org Sender: "Intel-wired-lan" Hello, I upgraded a machine from 3.14.x to v4.1.x and noted that I now have two kworker very often on D state, just after boot while I am not doing anything special. This issue remains indefinitely. This machine has four network interfaces: 01:00.0 Ethernet controller: Intel Corporation 82576 Gigabit Network Connection (rev 01) Subsystem: Inventec Corporation Device 004a Flags: bus master, fast devsel, latency 0, IRQ 17 Memory at fbce0000 (32-bit, non-prefetchable) [size=128K] Memory at fbcc0000 (32-bit, non-prefetchable) [size=128K] I/O ports at cc00 [size=32] Memory at fbc9c000 (32-bit, non-prefetchable) [size=16K] Expansion ROM at fbca0000 [disabled] [size=128K] Capabilities: [40] Power Management version 3 Capabilities: [50] MSI: Enable- Count=1/1 Maskable+ 64bit+ Capabilities: [70] MSI-X: Enable+ Count=10 Masked- Capabilities: [a0] Express Endpoint, MSI 00 Capabilities: [100] Advanced Error Reporting Capabilities: [140] Device Serial Number 00-26-6c-ff-ff-ff-af-71 Capabilities: [150] Alternative Routing-ID Interpretation (ARI) Capabilities: [160] Single Root I/O Virtualization (SR-IOV) Kernel driver in use: igb 01:00.1 Ethernet controller: Intel Corporation 82576 Gigabit Network Connection (rev 01) Subsystem: Inventec Corporation Device 004a Flags: bus master, fast devsel, latency 0, IRQ 16 Memory at fbc20000 (32-bit, non-prefetchable) [size=128K] Memory at fbc00000 (32-bit, non-prefetchable) [size=128K] I/O ports at c880 [size=32] Memory at fbbdc000 (32-bit, non-prefetchable) [size=16K] Expansion ROM at fbbe0000 [disabled] [size=128K] Capabilities: [40] Power Management version 3 Capabilities: [50] MSI: Enable- Count=1/1 Maskable+ 64bit+ Capabilities: [70] MSI-X: Enable+ Count=10 Masked- Capabilities: [a0] Express Endpoint, MSI 00 Capabilities: [100] Advanced Error Reporting Capabilities: [140] Device Serial Number 00-26-6c-ff-ff-ff-af-71 Capabilities: [150] Alternative Routing-ID Interpretation (ARI) Capabilities: [160] Single Root I/O Virtualization (SR-IOV) Kernel driver in use: igb 03:00.0 Ethernet controller: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Connection (rev 01) Subsystem: Inventec Corporation Device 004c Flags: bus master, fast devsel, latency 0, IRQ 56 Memory at fbdc0000 (64-bit, non-prefetchable) [size=256K] I/O ports at dc00 [size=32] Memory at fbd9c000 (64-bit, non-prefetchable) [size=16K] Expansion ROM at fbda0000 [disabled] [size=128K] Capabilities: [40] Power Management version 3 Capabilities: [50] MSI: Enable- Count=1/1 Maskable+ 64bit+ Capabilities: [70] MSI-X: Enable+ Count=64 Masked- Capabilities: [a0] Express Endpoint, MSI 00 Capabilities: [e0] Vital Product Data Capabilities: [100] Advanced Error Reporting Capabilities: [140] Device Serial Number 00-8c-fa-ff-ff-01-cf-c2 Capabilities: [150] Alternative Routing-ID Interpretation (ARI) Capabilities: [160] Single Root I/O Virtualization (SR-IOV) Kernel driver in use: ixgbe 03:00.1 Ethernet controller: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Connection (rev 01) Subsystem: Inventec Corporation Device 004c Flags: bus master, fast devsel, latency 0, IRQ 82 Memory at fbd40000 (64-bit, non-prefetchable) [size=256K] I/O ports at d880 [size=32] Memory at fbd1c000 (64-bit, non-prefetchable) [size=16K] Expansion ROM at fbd20000 [disabled] [size=128K] Capabilities: [40] Power Management version 3 Capabilities: [50] MSI: Enable- Count=1/1 Maskable+ 64bit+ Capabilities: [70] MSI-X: Enable+ Count=64 Masked- Capabilities: [a0] Express Endpoint, MSI 00 Capabilities: [e0] Vital Product Data Capabilities: [100] Advanced Error Reporting Capabilities: [140] Device Serial Number 00-8c-fa-ff-ff-01-cf-c2 Capabilities: [150] Alternative Routing-ID Interpretation (ARI) Capabilities: [160] Single Root I/O Virtualization (SR-IOV) Kernel driver in use: ixgbe The two ixgbe interfaces are not used (UP but no-carrier): 2: eth0: mtu 9000 qdisc mq state UP group defa link/ether 00:26:6c:ff:af:70 brd ff:ff:ff:ff:ff:ff inet 10.5.5.58/24 brd 10.5.5.255 scope global eth0 valid_lft forever preferred_lft forever 3: eth1: mtu 9000 qdisc mq state UP group defa link/ether 00:26:6c:ff:af:71 brd ff:ff:ff:ff:ff:ff 4: eth2: mtu 1500 qdisc mq state DOWN group link/ether 00:8c:fa:01:cf:c2 brd ff:ff:ff:ff:ff:ff 5: eth3: mtu 1500 qdisc mq state DOWN group link/ether 00:8c:fa:01:cf:c3 brd ff:ff:ff:ff:ff:ff if I turn them down (ip link set dev eth{2,3} down); the problem disappear, the two kworker in D disapper as well. Since I consider this as a regression because I only change the kernel version, I did a bisection in order to localize the issue. What I got at the end is: (bisected between v3.14.x and v4.1.x) # first bad commit: [d9cd46cd391a132a43cbde7bdac12c16284b618f] ixgbe: fix detection of SFP+ capable interfaces After some tests, I reverted the only part present in ixgbe_main: It also fixes my issue: even if eth{2,3} are still up with no carrier, I don't have any kworker in D state. So, is it something we should consider as a regression, in that case I can send a formal patch, or do you need some more information to help you debug it? Thanks, --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -4786,8 +4786,6 @@ case ixgbe_phy_qsfp_active_unknown: case ixgbe_phy_qsfp_intel: case ixgbe_phy_qsfp_unknown: - /* ixgbe_phy_none is set when no SFP module is present */ - case ixgbe_phy_none: return true; case ixgbe_phy_nl: if (hw->mac.type == ixgbe_mac_82598EB)